Make regsubst() sensitive-aware#354
Merged
corporate-gadfly merged 1 commit intoOpenVoxProject:mainfrom Mar 31, 2026
Merged
Conversation
Contributor
Author
|
My Commit was already 2024 merged to Puppet. |
Contributor
|
Why is this missing in openvox? 🤔 |
Contributor
|
@cocker-cc can you rebase please? I fixed some CI issues |
cocker-cc
force-pushed
the
Make_regsubst_sensitive-aware
branch
from
f438841 to
435b757
Compare
Contributor
|
@cocker-cc Also the commit needs a verified signature, TY. |
cocker-cc
force-pushed
the
Make_regsubst_sensitive-aware
branch
from
435b757 to
b6ebaf4
Compare
This commit updates regsubst() to take in Sensitive type targets. Specifically, regsubst() can now take targets that are either Sensitive String, Sensitive arrays that have a combination of String and/or Sensitive[String], or non-Sensitive arrays that have combination of String and/or Sensitive[String].
cocker-cc
force-pushed
the
Make_regsubst_sensitive-aware
branch
from
b6ebaf4 to
a2c8d9c
Compare
corporate-gadfly
approved these changes
Mar 31, 2026
Contributor
|
TY @cocker-cc . Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates regsubst() to take in Sensitive type targets. Specifically, regsubst() can now take targets that are either Sensitive String, Sensitive arrays that have a combination of String and/or Sensitive[String], or non-Sensitive arrays that have combination of String and/or Sensitive[String].