Skip to content

fix: use default params props if disabledShrink is falsy#252

Closed
tomrndom wants to merge 1 commit into
mainfrom
fix/company-v2-label-prop-default
Closed

fix: use default params props if disabledShrink is falsy#252
tomrndom wants to merge 1 commit into
mainfrom
fix/company-v2-label-prop-default

Conversation

@tomrndom
Copy link
Copy Markdown
Contributor

@tomrndom tomrndom commented May 22, 2026

ref: https://app.clickup.com/t/86ba2r32x

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where input label styling properties were not being properly applied to company input fields under certain conditions.

Review Change Stack

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e437ffce-df5b-4546-a9f9-52d4dfe1f9f9

📥 Commits

Reviewing files that changed from the base of the PR and between 1ea9d93 and 3bcc56a.

📒 Files selected for processing (1)
  • src/components/inputs/company-input-v2.js

📝 Walkthrough

Walkthrough

CompanyInputV2 now forwards MUI InputLabelProps from params to the underlying TextField component when disableShrink is false. Previously, InputLabelProps was omitted in that case, preventing Material-UI label configuration from being applied.

Changes

InputLabelProps Prop Forwarding

Layer / File(s) Summary
TextField InputLabelProps forwarding
src/components/inputs/company-input-v2.js
TextField now receives InputLabelProps={disableShrink ? { shrink: false } : params.InputLabelProps} instead of omitting the prop when disableShrink is false, allowing Material-UI label props to be preserved and applied.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A simple prop now flows so free,
Through TextField it shall gracefully be,
No labels lost when shrink is still,
Material-UI bends to our will!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: forwarding default params props to TextField when disableShrink is falsy, which matches the actual modification in CompanyInputV2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/company-v2-label-prop-default

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomrndom tomrndom closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant