Skip to content

fix: export formik mui select v2 component#245

Open
tomrndom wants to merge 1 commit into
mainfrom
fix/export-mui-select-v2
Open

fix: export formik mui select v2 component#245
tomrndom wants to merge 1 commit into
mainfrom
fix/export-mui-select-v2

Conversation

@tomrndom
Copy link
Copy Markdown
Contributor

@tomrndom tomrndom commented May 20, 2026

ref: https://app.clickup.com/t/86b9j5rez

Allow to use new component as requested at fntechgit/summit-admin#890 (comment)

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • New Features
    • Introduced a new form select component to expand available options for form building and user input selection.

Review Change Stack

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from santipalenque May 20, 2026 19:26
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7596d221-99c4-4658-aa24-01afa633ab50

📥 Commits

Reviewing files that changed from the base of the PR and between 1ea9d93 and 2142a4e.

📒 Files selected for processing (2)
  • src/components/index.js
  • webpack.common.js

📝 Walkthrough

Walkthrough

Adds MuiFormikSelectV2 to the public component barrel export and registers it as a Webpack entry point for UMD distribution alongside other MUI Formik input components.

Changes

Component Exposure and Build

Layer / File(s) Summary
MuiFormikSelectV2 public API and build entry
src/components/index.js, webpack.common.js
Component is exported from the barrel file to make it available as part of the public API, and added as a separate Webpack entry point to the UMD build configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • OpenStackweb/openstack-uicore-foundation#224: Introduces the MuiFormikSelectV2 component implementation and updates ItemTableField to use it; this PR complements by exposing the new component through the library's public API and build configuration.

Suggested reviewers

  • santipalenque
  • smarcet

Poem

🐰 A component takes form, with care and with style,
Exposed to the world through the barrel's compile,
Webpack is wired, the build knows its place,
SelectV2 now shines in this library's space! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: exporting a new formik Material-UI select v2 component by adding barrel exports and webpack entries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/export-mui-select-v2

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@santipalenque santipalenque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants