Add log stream for gRPC client#49
Open
4echow wants to merge 2 commits into
Open
Conversation
peb-adr
reviewed
May 29, 2026
Member
peb-adr
left a comment
peb-adr
left a comment
There was a problem hiding this comment.
Don't really know much about golang, pub/sub or grpc streaming lol.
Diff looks good (style wise), concise and like it will do what it is intended to do.
Just one remark.
Comment on lines
61
to
63
| func ParseLevel(levelStr string) (Level, error) { | ||
| return parseLevel(levelStr) | ||
| } |
Member
There was a problem hiding this comment.
Any reason for this nesting?
Looks this it's basically the same method and can be reduced to one.
Member
Author
There was a problem hiding this comment.
Fair point, just lazy wrapper to expose the function to the server endpoint. Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.