Skip to content

[codex] Add Notary CEL integration #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremi wants to merge 9 commits into
base: 19.0
Choose a base branch
from

Address Notary review tail gaps

b84609c
Select commit
Loading
Failed to load commit list.
Open

[codex] Add Notary CEL integration #219

Address Notary review tail gaps
b84609c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 29, 2026 in 1s

71.95% (+0.45%) compared to c660896

View this Pull Request on Codecov

71.95% (+0.45%) compared to c660896

Details

Codecov Report

❌ Patch coverage is 94.73189% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.95%. Comparing base (c660896) to head (b84609c).

Files with missing lines Patch % Lines
spp_notary_evidence/models/data_provider.py 92.26% 25 Missing ⚠️
spp_notary_client/services/audit_log.py 85.41% 7 Missing ⚠️
spp_notary_client/services/client.py 96.83% 7 Missing ⚠️
spp_notary_evidence/models/notary_claim.py 94.44% 6 Missing ⚠️
spp_cel_domain/models/cel_executor.py 92.45% 4 Missing ⚠️
spp_notary_client/services/schemas.py 97.08% 3 Missing ⚠️
spp_cel_domain/models/data_evaluator.py 90.00% 1 Missing ⚠️
spp_cel_domain/models/data_provider.py 94.11% 1 Missing ⚠️
spp_notary_client/__manifest__.py 0.00% 1 Missing ⚠️
spp_notary_evidence/__manifest__.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0     #219      +/-   ##
==========================================
+ Coverage   71.50%   71.95%   +0.45%     
==========================================
  Files        1001     1015      +14     
  Lines       58626    59685    +1059     
==========================================
+ Hits        41921    42948    +1027     
- Misses      16705    16737      +32
Files with missing lines Coverage Δ
spp_cel_domain/models/data_value.py 77.52% <100.00%> (+1.21%) ⬆️
spp_notary_client/services/__init__.py 100.00% <100.00%> (ø)
spp_notary_client/services/exceptions.py 100.00% <100.00%> (ø)
spp_notary_evidence/__init__.py 100.00% <100.00%> (ø)
spp_notary_evidence/models/__init__.py 100.00% <100.00%> (ø)
spp_notary_evidence/models/cel_variable.py 100.00% <100.00%> (ø)
spp_notary_evidence/wizards/__init__.py 100.00% <100.00%> (ø)
spp_notary_evidence/wizards/catalog_sync_wizard.py 100.00% <100.00%> (ø)
spp_cel_domain/models/data_evaluator.py 53.47% <90.00%> (+1.50%) ⬆️
spp_cel_domain/models/data_provider.py 95.65% <94.11%> (+10.12%) ⬆️
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov