DEV-325: migrate Chronicle-Values tests from JUnit 4 to JUnit 5#176
Open
DEV-325: migrate Chronicle-Values tests from JUnit 4 to JUnit 5#176
Conversation
Keep Vintage on the classpath so existing JUnit 4 tests continue to run while source is migrated to Jupiter. Versions come from the parent java-parent-pom (jupiter 5.10.0).
Mechanical migration of all 12 test classes from JUnit 4 to JUnit 5 (org.junit.jupiter.api) via OpenRewrite's JUnit4to5Migration recipe: - org.junit.Test -> org.junit.jupiter.api.Test - org.junit.Assert.* -> org.junit.jupiter.api.Assertions.* - @Before/@after -> @BeforeEach/@AfterEach - assertX(msg, expected, actual) -> assertX(expected, actual, msg) All 47 tests still pass; no behavioural changes. Dropping junit-vintage-engine now that no JUnit 4 source remains.
|
5 tasks
| } catch (AssertionError e) { | ||
| e.printStackTrace(); | ||
| assertFalse("Throws an IllegalArgumentException", true); | ||
| assertFalse(true, "Throws an IllegalArgumentException"); |
Member
There was a problem hiding this comment.
Looks like it shouldn't catch the AssertionError
peter-lawrey
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.junit) to JUnit 5 Jupiter (org.junit.jupiter.api).junit:junitforjunit-jupiter(versions inherited fromjava-parent-pom).Bulk-change context
Part of a coordinated cross-repo JUnit 4 → JUnit 5 migration tracked by Epic DEV-324.
Sibling PRs (in this batch):
Acceptance criteria
mvn clean installpasses locally (includes license:check and maven-bundle packaging)JaCoCo is not configured in this repo, so the coverage gate is N/A.
What changed mechanically
org.junit.Test→org.junit.jupiter.api.Testorg.junit.Assert.*→org.junit.jupiter.api.Assertions.*@Before/@After→@BeforeEach/@AfterEachNo production source changed.
Jira
DEV-325 — part of Epic DEV-324.
Fixes DEV-325.
🤖 Generated with Claude Code