Refactor/remove non obp lift#2814
Merged
simonredfern merged 3 commits intoMay 26, 2026
Merged
Conversation
…Polish/STET/MxOF) Comment out all 47 source files of BahrainOBF v1.0.0, AUOpenBanking v1.0.0, Polish v2.1.1.1, STET v1.4 and MxOF/CNBV9 so their ScannedApis objects drop out of reflection-based registration (ClassScanUtils.getSubTypeObjects) and no longer serve through the Lift bridge. Fix dependent references so the build and tests stay green: - APIUtil.allStaticResourceDocs: drop the 5 standards' resource doc aggregation - SwaggerJSONFactory: comment imports + license branches for AU/Polish/STET - Http4sLiftBridgePropertyTest: empty intlStandardsWithGetEndpoints - ApiCollectionEndpointTest: remove 5 operation_id blocks, count 9 -> 4
Commenting out STET v1.4, Polish v2.1.1.1, AUOpenBanking v1.0.0, BahrainOBF v1.0.0 and MxOF (OBP_MXOF v1.0.0 + CNBV9 v1.0.0) drops 6 scanned ApiVersions from the reflection-built registry, so ApiVersionUtilsTest's hardcoded count must follow.
hongwei1
force-pushed
the
refactor/removeNonOBPLift
branch
from
7aac9d0 to
aa21d89
Compare
|
constantine2nd
added a commit
to constantine2nd/OBP-API
that referenced
this pull request
May 26, 2026
…ired in migration doc + regression-guard test Companion to PR OpenBankProject#2814 (commit d19af2b) which commented out 5 non-OBP Lift API standards. The disable is structural — `ClassScanUtils.getSubTypeObjects` finds no `ScannedApis` in those packages, so Lift's dispatch never sees them and `Boot.scala` needs no change. The flip side is that a partial uncomment of any retired-standard file would silently re-register that standard at the next startup. Two changes: 1. **`LIFT_HTTP4S_MIGRATION.md`** — replace the five "Lift" rows in the Open-banking standards table with "Retired" (strike-through) entries, add a paragraph explaining the comment-out pattern + the deletion candidate timeline, and forward-reference the new regression-guard test. Section heading drops "(large, deferred indefinitely)" — only the BG v1.3 / UKOpenBanking / sandbox rows remain in-scope. 2. **`RetiredApiStandardsTest`** — scenario `"ScannedApis registry must not contain any object from a retired-standard package"`. Walks the live `ScannedApis.versionMapScannedApis` map and asserts no entry's fully-qualified class name starts with one of: code.api.BahrainOBF. code.api.AUOpenBanking. code.api.STET. code.api.Polish. code.api.MxOF. If anyone partially uncomments a retired standard, this test fails with the exact class name they brought back, and forces a re-think before the change ships. Uses `V400ServerSetup` because the scan needs a real classpath view (same hierarchy as `ApiVersionUtilsTest`, which counts scanned versions 26 → 20). Currently passes — confirms the empirical "zero scanned classes in the retired packages" invariant after PR OpenBankProject#2814.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.