[19.0][MIG] database_size: Migration to 19.0#3632
Open
dnplkndll wants to merge 3 commits into
Open
Conversation
Signed-off-by: Don Kendall <dkendall@ledoweb.com>
- read_group override → _read_group (19.0 deprecated public read_group + web no longer routes through it). New signature (groupby/aggregates/having/order); still defaults the group order for the report views. - search view: dropped `expand`/`string` from the Group By <group> (19.0 RelaxNG rejects them on search-view groups). - _sql_constraints → models.Constraint (kept uniq_model_measurement_date name). - report: f-strings inside self.env._() → %(name)s placeholders (19.0 pylint translation-fstring-interpolation). - _compute_model_name: justified `# pylint: disable=no-search-all` (small ir.model registry load). Signed-off-by: Don Kendall <dkendall@ledoweb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
database_sizefrom 18.0 to 19.0 (migration guide).Non-mechanical adaptations worth flagging
read_groupoverride →_read_group: 19.0 deprecated the publicread_group(would fail checklog) and the web client no longer routes group views through it, so the old override was both noisy and dead. Re-implemented on the non-deprecated_read_groupwith the 19.0 signature (groupby/aggregates/having/order); it still just defaults the group order for the size-report views._sql_constraints→models.Constraint(kept theuniq_model_measurement_datename)._compute_model_name: justified# pylint: disable=no-search-allon their.modelload (small registry table; new 19.0 pylint-odoo check). Theinformation_schemareferences are raw table-size SQL, unrelated to translatable-field jsonb assumptions.