[19.0][MIG] module_analysis: Migration to 19.0#3631
Open
dnplkndll wants to merge 33 commits into
Open
Conversation
fixup! [ADD] new module module_analysis fixup! fixup! [ADD] new module module_analysis fixup! fixup! fixup! [ADD] new module module_analysis fixup! fixup! fixup! fixup! [ADD] new module module_analysis IMP exception message fixup! fixup! fixup! fixup! fixup! [ADD] new module module_analysis [REF] remove use of cloc. use pygount librairy instead fixup! [REF] remove use of cloc. use pygount librairy instead fixup! fixup! [REF] remove use of cloc. use pygount librairy instead Apply suggestions from code review Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/views/menu.xml Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/tests/test_module.py Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/readme/CONFIGURE.rst Co-Authored-By: David Beal <david.beal@akretion.com> [IMP] handle encoding [UPD] Update module_analysis.pot [UPD] README.rst [UPD] README.rst
[MIG] module_analysis: Migration to 15.0
…cause the analysis is partial (it also make the update slower) ; Add instead a cron task that is executed nightly to update analysis automatically
Analyse can take some time and a cron task can do it every day if needed, no need to recompute it in real time
…e there is no post install hook anymore
… cron. Usefull if we want to analyse the code for uninstalled modules for instance
…e to module's folder Fixes OCA#3042.
Pin the pygount dependency to 1.4.0 to avoid chardet version clash Fixes OCA#2966
pygount 1.4.0 is now very old and current code does not work on recent versions. It is however easy to improve compatibility accross pygount versions using the code_count property instead of the code one, which was removed in 2.0.0. That way, pygount 1.4.0 stays supported but also modern version up to at least 3.1.0.
Signed-off-by: Don Kendall <dkendall@ledoweb.com>
- _sql_constraints → models.Constraint (19.0 API); kept the name_uniq constraint name. - pygount added to repo-root requirements.txt (module's external_dependencies; absent on 19.0, needed for CI install). - _analyse_code: justified `# pylint: disable=no-search-all` on the ir.module.type.rule load (small config table; new 19.0 pylint-odoo check). Signed-off-by: Don Kendall <dkendall@ledoweb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
module_analysisfrom 18.0 to 19.0 (migration guide).Non-mechanical adaptations worth flagging
_sql_constraints→models.Constraint(19.0 API); kept thename_uniqconstraint name so the DB identity is stable.pygount(the LoC counter this module needs) added to repo-rootrequirements.txt— it was absent on the 19.0 branch, so CI needs it to install the module.