Skip to content

[IMP] queue_job_batch: Add batch execution_time field.#937

Open
amh-mw wants to merge 1 commit into
OCA:18.0from
amh-mw:18.0-batch-execution_time
Open

[IMP] queue_job_batch: Add batch execution_time field.#937
amh-mw wants to merge 1 commit into
OCA:18.0from
amh-mw:18.0-batch-execution_time

Conversation

@amh-mw
Copy link
Copy Markdown
Member

@amh-mw amh-mw commented May 19, 2026

This also adds an _on_done hook that retries until the entire batch is complete.

@amh-mw amh-mw marked this pull request as ready for review May 19, 2026 15:38
@amh-mw
Copy link
Copy Markdown
Member Author

amh-mw commented May 19, 2026

The _on_done hook collapses an entire batch job (potentially containing millions of jobs) into a single node in the graph.

@amh-mw
Copy link
Copy Markdown
Member Author

amh-mw commented May 19, 2026

While testing, it appears that the recurring check_state job is added to the batch and is hanging. Investigating...
Edit: Fixed.

@amh-mw amh-mw force-pushed the 18.0-batch-execution_time branch from fdf659d to 4aca6cc Compare May 20, 2026 11:36
@amh-mw amh-mw force-pushed the 18.0-batch-execution_time branch from 4aca6cc to 84ee51b Compare June 1, 2026 16:28
@amh-mw
Copy link
Copy Markdown
Member Author

amh-mw commented Jun 1, 2026

Added test coverage.

This also adds an _on_done hook that retries until the entire
batch is complete.
@amh-mw amh-mw force-pushed the 18.0-batch-execution_time branch from 84ee51b to 29c1e85 Compare June 1, 2026 19:01
@amh-mw
Copy link
Copy Markdown
Member Author

amh-mw commented Jun 1, 2026

I renamed _on_finished to _on_done after I noticed that only successful jobs are finished; the chained job should execute even after failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants