feat(fleet-identity): add version() function for upgrade verification#108
Merged
feat(fleet-identity): add version() function for upgrade verification#108
Conversation
- Add virtual version() returning '1.0.0' to FleetIdentityUpgradeable - Update V2 mock to override with '2.0.0' - Add test_FleetIdentity_Version and test_FleetIdentity_VersionChangesAfterUpgrade - Fix override specifier in TestUpgradeOnAnvil V2 mock
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a
version()function toFleetIdentityUpgradeableto enable reliable post-upgrade verification.Changes
Added
version()function toFleetIdentityUpgradeable.solreturning"1.0.0"virtualto allow overriding in upgraded implementationsUpdated test mocks to override with appropriate versions
"2.0.0"Added comprehensive tests
test_FleetIdentity_Version— verifies base contract returns"1.0.0"test_FleetIdentity_VersionChangesAfterUpgrade— confirms proxy reflects new version after upgradeTesting
All 20 upgrade tests pass, including new version verification tests.
Upgrade Verification
After deploying a FleetIdentity upgrade, call:
The result should match the new implementation's version string, confirming the upgrade is live and executing new code.