Merged
Conversation
…ipts - Rename PAYMASTER_ADMIN/OWNER → NODL_ADMIN in both L1 and ZkSync Forge scripts and shell wrappers since the owner role applies to all contracts (ServiceProvider, FleetIdentity, SwarmRegistry), not just the paymaster - Keep PAYMASTER_WITHDRAWER for the paymaster-specific withdrawer role - Fix undefined $deployer fallback: derive DEPLOYER_ADDRESS via cast wallet address in both shell scripts - Fix print_summary referencing nonexistent $OWNER/$NODLE_SWARM_OPERATOR variables in ZkSync shell script - Add COUNTRY_MULTIPLIER to env var documentation in all scripts - Add 0x prefix normalization and deployer address derivation to L1 shell script for consistency with ZkSync script
forge script --verify sends absolute source paths which the ZkSync
block explorer verifier rejects ('import with absolute or traversal
path'). Replace with a separate verify_source_code() step that:
1. Flattens each contract into a single .sol file (no imports)
2. Copies flat files into src/ temporarily
3. Runs forge verify-contract with the flat source
4. Extracts constructor args from the broadcast JSON automatically
5. Cleans up temporary files
Also:
- Add per-network VERIFIER_URL and FORGE_CHAIN in config section
(mainnet: zksync2-mainnet-explorer.zksync.io/contract_verification,
testnet: explorer.sepolia.era.zksync.dev/contract_verification)
- Remove --verify from forge script args (broken on ZkSync)
- Wire verify_source_code into main() between verify_deployment and
update_env_file
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates deployment and configuration improvements for production swarm deployment on ZkSync.
Changes