[18.0][IMP] delivery_dhl_parcel_de: Added DHL configuration in delive… by hitesh-erpharbor · Pull Request #253 · Nitrokey/odoo-modules

hitesh-erpharbor · 2026-02-27T13:14:30Z

…ry method account

Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.pl>

This reverts commit ba7c8b8.

Co-authored-by: KDRdev <dmytro.kashuba@solvti.com>

* Migration of payment_bitcoin to 18.0 --------- Co-authored-by: KDRdev <dmytro.kashuba@solvti.com> Co-authored-by: Jan Suhr <jan@nitrokey.com> Co-authored-by: HItesh Jadav <hitesh.j.erpharbor@gmail.com>

Removed whool-init hook from pre-commit configuration.

* add author Nitrokey * [MIG] Migrated the modules product_icon, website_sale_product_icon from v15 to v18 --------- Co-authored-by: HItesh Jadav <hitesh.j.erpharbor@gmail.com>

--------- Co-authored-by: HItesh Jadav <hitesh.j.erpharbor@gmail.com>

… controller method (#212)

Removed forbidden files checks and OCA hooks from pre-commit config.

#213) * [18.0][MIG] Migrated module website_menu_url_translate from v15 to v18 * [ADD/IMP] Implemented the translation controller and Added the test data file and test .py file * Update author and website fields in manifest * Simplify README by removing usage and credits Removed detailed usage instructions and credits from README. * fix title Updated the formatting of the README to improve consistency. --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

* [18.0][MIG] Migrated module website_menu_url_translate from v15 to v18 * [ADD/IMP] Implemented the translation controller and Added the test data file and test .py file * Update author and website fields in manifest * [IMP/REM] Implemented the test py file and Remove test data xml file * [IMP] Implemented the formarting to pass the CI tests * [IMP] Implemented the formarting to pass the CI tests * [IMP] Implemented the readme file * fix README --------- Co-authored-by: jans23 <jans23@users.noreply.github.com> Co-authored-by: Jan Suhr <jan@nitrokey.com>

* mail_sound from 15.0 * initial migration * add README, fix syntax * add pyproject.toml * remove whool from pre-commit, pyproject.toml * [18.0][MIG] Migrated the module mail_sound into v18 * [FIX] Implemented the code to pass the CI tests * [IMP] Implemented the file path of js * [IMP] Implemented the code to fixed the CI tests [IMP] Implemented the code [IMP] Implmented the code to fix the CI * [IMP] Commented the .yaml file eslint code to fix the CI * [IMP] Uncomment the .yaml file eslint code * fix path for eslint * update description * fix pylint, eslint * fix linter --------- Co-authored-by: HItesh Jadav <hitesh.j.erpharbor@gmail.com>

* Hide Bitcoin payment method, if no addresses are provided * remove pyproject.toml --------- Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.pl> Co-authored-by: Jan Suhr <jan@nitrokey.com>

…te_description: Migration to v18.0 (#221) * [18.0][MIG] product_attribute_description: migration to v18.0 * [18.0][MIG] website_product_attribute_description: Migration to v18.0 * update descriptions * [18.0][IMP] Display info (i) icon inline next to attribute values. --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

* [18.0][MIG] sale_order_default_payment_term: Migration to v18.0 * Update website URL in manifest file --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

#220) * refactor phone validation: remove unused files and implement E164 formatting in res_partner * fix: update website link in manifest and enhance phone formatting logic in res_partner * Refactor README for clarity and conciseness Removed redundant description and cleaned up formatting. * refactor: improve README and manifest formatting for clarity, Fixed CLI * feat: enhance phone validation with comprehensive tests and update author information in manifest; Fixing the pytest issue * fix: update phone number formatting in test cases for consistency in regard to phone_validation_e164 * Update author information in __manifest__.py --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

* [18.0][MIG] product_label_image: Migration to v18.0 * [IMP] Implememeted the report image format * Update author information in manifest file * [IMP] Remove the light-grey-blue background color behind the product name * [REM] Remove README file * [ADD] Added README file * [ADD] Implemented README file --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

* [18.0][MIG] account_invoice_send_on_reconcile: Migration to v18.0 * Update README for clarity on module functionality --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

* [18.0][MIG] mail_activity_portal: Migration to v18.0 * Update website and author information in manifest * [REM] Removed mail_activity_team and mail_activity_board modules from branch * Update README with testing instructions Added testing instructions for portal activity scheduling. --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

* [18.0][MIG] product_creation_prevention: Migration to v18.0 * Fix formatting in README for product creation module --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

* Module migration to 18.0 * Update website URL in manifest file * Updated tests and manifest * Ruff checks fixed * README file update and removal of unnecessary description --------- Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.pl> Co-authored-by: jans23 <jans23@users.noreply.github.com>

* add stock_lot_serial_no_default * Update README with serial number column instructions Added note about enabling 'Serial Number' column in delivery orders. * Update website URL in manifest file

* [ADD] datev_export_dtvf_nitrokey * Revise README and Manifest --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

…e conflict (#241)

* Module migration to 18.0 - initial version * Added package weight validation, CI fixes, README file * Pre-commit fixes * Small formatting fix * Pre-commit fix #2 * README, manifest and dependencies update * OAuth2 implementation, merged newer module version from original author * Fix for multiple package types during weight limitation check. Added API secret field to view * Added neutralization script * pre-commit fix * README update * update description --------- Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.pl> Co-authored-by: jans23 <jans23@users.noreply.github.com>

* [ADD] datev_export_xml_nitrokey * create data for tests to work without demo data * fix tests * fix tests * fix syntax --------- Co-authored-by: Holger Brunn <mail@hunki-enterprises.com>

#243) * [18.0][IMP] website_menu_url_translate: Implemented the code to fix the home page route issue * [18.0][IMP] website_menu_url_translate: FIxed the URL conflict issue * [18.0][IMP] website_menu_url_translate: Removed the extra code * [18.0][IMP] website_menu_url_translate: Implemented url method to fix page issue * Clean up main.py by removing unused comments Removed commented-out code for default language URL handling. --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

* send warning to account manager * [18.0][IMP] payment_bitcoin: Improved the send warning to account manager code --------- Co-authored-by: Hitesh Jadav <hitesh.j.erpharbor@gmail.com>

* refactored, simplified, more odoo * updated readme * imporved muting * null check * add UI check * add audio element to DOM * null check * updated manifest * added additional mute handling * added additional mute handling * added additional mute handling * improved clean up * nullcheck * address various possible errors * address various possible errors * address various possible errors * address various possible errors * address various possible errors * extended clean up * committed to livekit managing audio streams * tied voulme control to audio elements * trigger rebind on connect * changed rebind logic * move rebind to livekit service * Delete odoo.conf * Delete mail_livekit/streamIssue.md * Rename JS file to avoid liner errors * Rename JS file to avoid linter errors * Update author information in manifest * additional cleanup on disconnect --------- Co-authored-by: Dmytro Kashuba @ Solvti <dmitry.kashuba.cv@gmail.com> Co-authored-by: jans23 <jans23@users.noreply.github.com>

Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.com>

…ry method account

…r data from company to delivery account

KDRdev · 2026-03-10T12:46:55Z

 from . import delivery_carrier
 from . import package_details
-from . import res_company
+from . import res_company  # Tempororily model


Why can't we remove this import statement?

This is because the data comes from the old model and is being used during migration into the new model. We can remove this file after the data migration is completed.

We're moving the current data from res_company to a temporary table before module is being loaded, so we don't need to have the old model in place ('res.company' in this case). Or am I missing something?

You're correct. Since the data is now being migrated to a temporary table before the module loads, the old 'res.company' model is no longer required. I have removed it.

KDRdev · 2026-03-16T17:18:36Z

+            company_id = data.pop("company_id")
+            use_dhl = data.pop("use_dhl_parcel_de_shipping_provider")
+
+            if not use_dhl:


In pre-migration script we're creating 'temp_dhl_company_data' table based on companies that have this checkbox enabled, so I think these two lines are not needed here.

KDRdev · 2026-03-16T17:23:03Z

+                continue
+
+            existing = env.ref("delivery_dhl_parcel_de.dhl_carrier_account")
+            if existing and existing.use_dhl_parcel_de_shipping_provider:


Why do we need this check?

I have updated the code

KDRdev · 2026-03-16T17:25:55Z

+        string="Use DHL Parcel DE Shipping Provider",
+        help="If use DHL Parcel DE shipping provider than value set TRUE.",
+        default=False,
+    )  # Tempororily field


I guess we wanted to use this field for migrating existing credentials, right? Why not just set 'delivery_type' field value? We can then not use this field, for post-migration script as well.

I removed it because it's no longer needed.

KDRdev · 2026-03-16T17:28:11Z

+            account_vals = {
+                "company_id": company_id,
+                "carrier_id": dhl_carrier.id,
+                "use_dhl_parcel_de_shipping_provider": True,


I'd remove this field and set 'delivery_type' value to 'dhl_parcel_de_provider' instead.

KDRdev · 2026-03-16T17:56:51Z

+    <record id="dhl_carrier_account" model="carrier.account">
+        <field name="name">DHL Parcel DE Account</field>
+        <field name="delivery_type">dhl_parcel_de_provider</field>
+        <field name="account">dummy</field>


Suggested change

<field name="account">dummy</field>

It's a required field, so we need to set something.

KDRdev · 2026-03-16T17:56:59Z

+        <field name="name">DHL Parcel DE Account</field>
+        <field name="delivery_type">dhl_parcel_de_provider</field>
+        <field name="account">dummy</field>
+        <field name="password">dummy</field>


Suggested change

<field name="password">dummy</field>

It's a required field, so we need to set something.

KDRdev · 2026-03-16T17:57:38Z

+                continue
+
+            existing = env.ref("delivery_dhl_parcel_de.dhl_carrier_account")
+            if existing and existing.use_dhl_parcel_de_shipping_provider:


Suggested change

if existing and existing.use_dhl_parcel_de_shipping_provider:

if existing and existing.account and existing.password:

I have implemented it.

KDRdev · 2026-03-16T17:58:51Z

+            account_vals = {
+                "company_id": company_id,
+                "carrier_id": dhl_carrier.id,
+                "use_dhl_parcel_de_shipping_provider": True,


Suggested change

"use_dhl_parcel_de_shipping_provider": True,

KDRdev · 2026-03-16T18:01:39Z

 from . import delivery_carrier
 from . import package_details
-from . import res_company
+from . import res_company  # Tempororily model


We're moving the current data from res_company to a temporary table before module is being loaded, so we don't need to have the old model in place ('res.company' in this case). Or am I missing something?

…ny model fields

Dmytro Kashuba and others added 30 commits September 11, 2025 15:25

Init 18.0 branch

3dd0fca

Pre-commit config from OCA 18.0 repos (#194)

69ad53d

Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.pl>

Add Github workflows (#195)

ba7c8b8

Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.pl>

Revert "Add Github workflows (#195)" (#198)

a53f72b

This reverts commit ba7c8b8.

Add Github pre-commit workflow (#199)

e7d18a0

Co-authored-by: KDRdev <dmytro.kashuba@solvti.com>

Adding payment_bitcoin for V15 before module migration to V18 (#200)

16f7ab0

Co-authored-by: KDRdev <dmytro.kashuba@solvti.com>

Migration of payment_bitcoin to 18.0 (#201)

b0ea5d6

* Migration of payment_bitcoin to 18.0 --------- Co-authored-by: KDRdev <dmytro.kashuba@solvti.com> Co-authored-by: Jan Suhr <jan@nitrokey.com> Co-authored-by: HItesh Jadav <hitesh.j.erpharbor@gmail.com>

Remove whool-init hook from .pre-commit-config.yaml

78ecf9b

Removed whool-init hook from pre-commit configuration.

Remove 'manifest-required-author' from mandatory checks

1cd2180

18.0 website_sale_product_icon, product_icon (#205)

1bfdd02

* add author Nitrokey * [MIG] Migrated the modules product_icon, website_sale_product_icon from v15 to v18 --------- Co-authored-by: HItesh Jadav <hitesh.j.erpharbor@gmail.com>

18.0 website_sale_embargo (#204)

1a44807

--------- Co-authored-by: HItesh Jadav <hitesh.j.erpharbor@gmail.com>

auth_oauth_disable_password (#208)

64426ea

payment_bitcoin: Added the Testing section in the README.rst (#211)

92d0cde

[IMP] Updated the PO file of module payment_bitcoin, and improved the…

19e3676

… controller method (#212)

remove OCA hooks (#214)

768b00f

Removed forbidden files checks and OCA hooks from pre-commit config.

fix deprecation warning (#216)

878ca40

merge_duplicate_contacts (#209)

ef6af7d

[ADD/MIG] Added migrated module ecommerce_first_last_name in v18 (#217)

a8bda39

[IMP] Hide Bitcoin payment method, if no addresses are provided (#218)

38c4401

* Hide Bitcoin payment method, if no addresses are provided * remove pyproject.toml --------- Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.pl> Co-authored-by: Jan Suhr <jan@nitrokey.com>

[18.0][MIG] sale_order_default_payment_term: Migration to v18.0 (#222)

6392803

* [18.0][MIG] sale_order_default_payment_term: Migration to v18.0 * Update website URL in manifest file --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

Fix formatting in README to solve warning

a188efc

[18.0][MIG] account_invoice_send_on_reconcile: Migration to v18.0 (#224)

597c42d

* [18.0][MIG] account_invoice_send_on_reconcile: Migration to v18.0 * Update README for clarity on module functionality --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

[18.0][MIG] product_creation_prevention: Migration to v18.0 (#229)

e3637dd

* [18.0][MIG] product_creation_prevention: Migration to v18.0 * Fix formatting in README for product creation module --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

KDRdev and others added 18 commits January 5, 2026 09:47

add stock_lot_serial_no_default (#231)

423d327

* add stock_lot_serial_no_default * Update README with serial number column instructions Added note about enabling 'Serial Number' column in delivery orders. * Update website URL in manifest file

[ADD] datev_export_dtvf_nitrokey (#237)

1f1a3ba

* [ADD] datev_export_dtvf_nitrokey * Revise README and Manifest --------- Co-authored-by: jans23 <jans23@users.noreply.github.com>

fix deprecation warning (#238)

23a88ac

add calendar_ics_url (#239)

f54546e

[18.0][IMP] Improved the code to fixed the mass_mailing_partner modul…

67ea96e

…e conflict (#241)

18.0 datev_export_xml_nitrokey tests (#244)

ed6912f

* [ADD] datev_export_xml_nitrokey * create data for tests to work without demo data * fix tests * fix tests * fix syntax --------- Co-authored-by: Holger Brunn <mail@hunki-enterprises.com>

send warning to account manager (#247)

792e12e

* send warning to account manager * [18.0][IMP] payment_bitcoin: Improved the send warning to account manager code --------- Co-authored-by: Hitesh Jadav <hitesh.j.erpharbor@gmail.com>

fix access groups (#249)

03e2b49

product_icon: fix access group

6b0b179

Fix for DHL label generation, message formatting (#248)

c9ef135

Co-authored-by: Dmytro Kashuba <dmytro.kashuba@solvti.com>

[18.0][IMP] delivery_dhl_parcel_de: Added DHL configuration in delive…

0d20221

…ry method account

[18.0][IMP] delivery_dhl_parcel_de: Fix CI test conflict

3d5c436

[18.0][IMP] delivery_dhl_parcel_de: Added migration scripts to trasfe…

f4ae6a4

…r data from company to delivery account

[18.0][IMP] delivery_dhl_parcel_de: Fix CI tests

3d097d5

KDRdev reviewed Mar 10, 2026

View reviewed changes

hitesh-erpharbor added 3 commits March 16, 2026 15:06

[IMP] delivery_dhl_parcel_de: Removed DHL bolean field

5f9e096

[IMP] delivery_dhl_parcel_de: Removed DHL bolean field

dd8cc5d

[IMP] Rechanged the Mail Sound Notifications version

f812ad9

jans23 reviewed Mar 16, 2026

View reviewed changes

Comment thread delivery_dhl_parcel_de/README.rst Outdated

[IMP] Implemented README file

2b618cb

KDRdev requested changes Mar 20, 2026

View reviewed changes

hitesh-erpharbor added 2 commits March 26, 2026 11:34

[IMP] Implemented PRE and POST migration script and removed res_compa…

47a026a

…ny model fields

[IMP] Implemented PRE and POST migration script and removed res_compa…

da9da87

…ny model fields

jans23 closed this Apr 12, 2026

jans23 force-pushed the 18.0 branch from 00d8db4 to 9bd2269 Compare April 12, 2026 11:15

	if existing and existing.use_dhl_parcel_de_shipping_provider:
	if existing and existing.account and existing.password:

Conversation

hitesh-erpharbor commented Feb 27, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hitesh-erpharbor Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hitesh-erpharbor Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hitesh-erpharbor Mar 26, 2026 •

edited

Loading

hitesh-erpharbor Mar 26, 2026 •

edited

Loading