Make distributed fused lamb test names friendly to keyword filtering#1698
Open
crcrpar wants to merge 3 commits intoNVIDIA:masterfrom
Open
Make distributed fused lamb test names friendly to keyword filtering#1698crcrpar wants to merge 3 commits intoNVIDIA:masterfrom
crcrpar wants to merge 3 commits intoNVIDIA:masterfrom
Conversation
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is merely cosmetic as the current parametrization creates test case names such as
NcclDistributedFusedLAMB.test_distributed_fused_lamb_no_copy_True_opt_kwargs_{'overlap_reductions': False, 'dwu_num_blocks': 1, 'dwu_num_chunks': 1, 'fused_norm': True, 'fuse_scale': True, 'clip_after_ar': False}whic is not ideally friendly to keyword filtering.it might be worth thinking of removing
no_copycheck hereapex/apex/contrib/optimizers/distributed_fused_lamb.py
Lines 160 to 166 in f03c6fb
cc @ptrblck @eqy @Aidyn-A