New: [AEA-6254] - RestApiGateway construct#547
Merged
tstephen-nhs merged 19 commits intomainfrom Mar 27, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6254 |
4f14152 to
02b0af2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new AWS CDK construct (RestApiGateway) to standardize provisioning of an API Gateway REST API (custom domain, logging/subscriptions, optional mTLS), plus a small helper construct for wiring Lambda-backed resources.
Changes:
- Introduces
RestApiGatewayconstruct with access logging, Splunk/optional CSOC log forwarding, custom domain + Route53 record, and optional mTLS truststore deployment. - Adds
LambdaEndpointconstruct and shared access log format helper. - Adds Vitest-based CDK assertions tests for the new constructs and minor repo/tooling config updates.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sonar-project.properties | Adds Sonar exclusions for specific vitest config files |
| packages/cdkConstructs/tests/constructs/RestApiGateway/LambdaEndpoint.test.ts | New tests for LambdaEndpoint construct |
| packages/cdkConstructs/tests/constructs/RestApiGateway.test.ts | New tests for RestApiGateway behavior (mTLS / CSOC logs) |
| packages/cdkConstructs/src/index.ts | Exports the new constructs/helpers from the package entrypoint |
| packages/cdkConstructs/src/constructs/RestApiGateway/accessLogFormat.ts | Defines a custom API Gateway access log JSON format |
| packages/cdkConstructs/src/constructs/RestApiGateway/LambdaEndpoint.ts | Adds helper construct to attach Lambda integrations to API resources |
| packages/cdkConstructs/src/constructs/RestApiGateway.ts | Implements the new RestApiGateway construct |
| .trivyignore.yaml | Adds a new CVE ignore entry (time-bounded) |
| .gitignore | Ignores *.tgz artifacts |
| .devcontainer/Dockerfile | Installs git-secrets in the devcontainer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/cdkConstructs/tests/constructs/RestApiGateway/LambdaEndpoint.test.ts
Outdated
Show resolved
Hide resolved
packages/cdkConstructs/src/constructs/RestApiGateway/LambdaEndpoint.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6a7beb5 to
0ac46b1
Compare
wildjames
reviewed
Mar 26, 2026
wildjames
reviewed
Mar 26, 2026
67db67f to
70e7f20
Compare
wildjames
approved these changes
Mar 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Details
Add a new CDK construct for API Gateway