feat: admin ability feed detail page by Alessandro100 · Pull Request #88 · MobilityData/mobilitydatabase-web

Alessandro100 · 2026-03-25T13:35:59Z

Summary:

closes #36

Added an admin view in the feed detail page only accessible to users with @mobilitydata.org email addresses

Expected behavior:

When you are logged in with a mobilitydata email address you will see an admin section at the bottom of each feed detail page

Testing tips:

Open 2 different browser
Browser 1: Do not log in, go to a feed detail page (mark down the 'generated at' value)
Browser 2: Log into your mobility data account, go to the same feed detail page, you should see the admin section at the bottom

In browser 2, revalidate the cache, then refresh browser 1, you should see the 'generated at' value update

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

vercel · 2026-03-25T13:36:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
mobilitydatabase-web	Ready	Preview, Comment	Mar 25, 2026 2:19pm

Copilot

Pull request overview

Adds an admin-only tool section to the Feed Detail page (served via the authed feed route rewrite) that allows MobilityData staff to trigger ISR cache revalidation for a specific feed, and refactors existing revalidation logic into a shared utility.

Changes:

Add an admin check (@mobilitydata.org) and plumb an isMobilityDatabaseAdmin flag into the authed feed page → FeedView.
Introduce a server action + client button to trigger revalidation for a specific feed.
Extract revalidation helpers into src/app/utils/revalidate-feeds.ts and reuse them from /api/revalidate.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/app/utils/revalidate-feeds.ts	New shared helpers for revalidating feed-related paths/tags.
src/app/utils/auth-server.ts	Adds `isMobilityDatabaseAdmin` helper used by page + server action.
src/app/screens/Feed/actions.ts	New server action to revalidate a specific feed’s cache with admin gating.
src/app/screens/Feed/components/RevalidateCacheButton.tsx	New client UI to call the server action and show result.
src/app/screens/Feed/FeedView.tsx	Renders admin tools section when `isMobilityDatabaseAdmin` is true.
src/app/components/ContentBox.tsx	Adds a new prop to support a subtitle-like section in ContentBox.
src/app/api/revalidate/route.ts	Refactors to use the shared revalidation utilities.
src/app/[locale]/feeds/[feedDataType]/[feedId]/authed/page.tsx	Computes admin status from cookie user and passes it to `FeedView`.

Applied skill: vercel-react-best-practices (server/client boundaries and server action usage).

src/app/components/ContentBox.tsx

src/app/screens/Feed/FeedView.tsx

Copilot · 2026-03-25T13:44:36Z

src/app/screens/Feed/FeedView.tsx

+        <ContentBox
+          title={'MobilityDatabase Admin Tools'}
+          subtile={
+            <>
+              This section is only visible to Mobility Data employees with an{' '}
+              <code>@mobilitydata.org</code> email address. It contains tools
+              for debugging and managing feed data
+            </>


The new admin section strings are hardcoded English, but this page already uses next-intl translations (getTranslations(...)). To keep localization consistent (especially for /fr), move these new strings into the message catalogs and render them via t(...).

src/app/screens/Feed/components/RevalidateCacheButton.tsx

src/app/screens/Feed/FeedView.tsx

Copilot · 2026-03-25T13:44:37Z

src/app/screens/Feed/actions.ts

+  revalidateSpecificFeeds([feedId]);
+  return { ok: true, message: `Cache revalidated for feed ${feedId}` };


This server action assumes feedId is always a meaningful non-empty string. Given the UI currently passes feed.id ?? '', consider validating feedId (e.g., trim().length > 0) and returning an error instead of calling revalidateSpecificFeeds with an empty id.

Suggested change

revalidateSpecificFeeds([feedId]);

return { ok: true, message: `Cache revalidated for feed ${feedId}` };

const normalizedFeedId = feedId.trim();

if (normalizedFeedId.length === 0) {

return { ok: false, message: 'Invalid feed id: value is empty or whitespace' };

}

revalidateSpecificFeeds([normalizedFeedId]);

return { ok: true, message: `Cache revalidated for feed ${normalizedFeedId}` };

Copilot · 2026-03-25T13:44:37Z

src/app/screens/Feed/components/RevalidateCacheButton.tsx

+      <Button variant='contained' onClick={handleClick} disabled={isPending}>
+        {isPending ? 'Revalidating…' : 'Revalidate The Cache of This Page'}
+      </Button>


The button label / status text is hardcoded. Since the app is localized with next-intl, consider moving these strings into the message files and using translations so admin users on /fr don't see mixed-language UI.

src/app/utils/auth-server.ts

Copilot · 2026-03-25T13:44:37Z

src/app/screens/Feed/FeedView.tsx

+      {isMobilityDatabaseAdmin && (
+        <ContentBox
+          title={'MobilityDatabase Admin Tools'}
+          subtile={
+            <>
+              This section is only visible to Mobility Data employees with an{' '}
+              <code>@mobilitydata.org</code> email address. It contains tools
+              for debugging and managing feed data
+            </>
+          }
+          outlineColor='background.paper'
+          sx={{ mt: 4, backgroundColor: 'background.paper' }}
+        >
+          <RevalidateCacheButton feedId={feed.id ?? ''} />
+        </ContentBox>


There are existing unit tests for the Feed screen (Feed.spec.tsx), but the new admin-only section and revalidation flow are currently untested. Consider adding tests that verify the admin tools render only when isMobilityDatabaseAdmin is true and that unauthorized users don’t see/can’t trigger revalidation.

github-actions · 2026-03-25T13:45:49Z

*Lighthouse ran on https://mobilitydatabase-ijl5r8khy-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 96	🟢 96	🟢 100	🟢 100

*Lighthouse ran on https://mobilitydatabase-ijl5r8khy-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 90	🟠 87	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-ijl5r8khy-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 75	🟢 94	🟢 96	🟢 100

*Lighthouse ran on https://mobilitydatabase-ijl5r8khy-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 78	🟠 83	🟢 100	🟢 100

*Lighthouse ran on https://mobilitydatabase-ijl5r8khy-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 81	🟢 94	🟢 96	🟢 100

Alessandro100 added 2 commits March 25, 2026 09:31

admin section in feed view

77fdc3b

ability to revalidate from feed page

f508b98

Alessandro100 requested a review from Copilot March 25, 2026 13:35

Alessandro100 self-assigned this Mar 25, 2026

Copilot started reviewing on behalf of Alessandro100 March 25, 2026 13:36 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Alessandro100 added 5 commits March 25, 2026 09:47

subtitle typo

39d6908

revalidate error catching

7a1a1ce

contentbox optional border color

2eb6040

safe guarding the admin email verification

8dfa848

lint

e611722

vercel bot deployed to Preview March 25, 2026 14:19 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: admin ability feed detail page#88

feat: admin ability feed detail page#88
Alessandro100 wants to merge 7 commits intomainfrom
feat/36-admin-ability-feed-detail-page

Alessandro100 commented Mar 25, 2026

Uh oh!

vercel bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		revalidateSpecificFeeds([feedId]);
		return { ok: true, message: `Cache revalidated for feed ${feedId}` };

-  revalidateSpecificFeeds([feedId]);
-  return { ok: true, message: `Cache revalidated for feed ${feedId}` };
+  const normalizedFeedId = feedId.trim();
+  if (normalizedFeedId.length === 0) {
+    return { ok: false, message: 'Invalid feed id: value is empty or whitespace' };
+  }
+  revalidateSpecificFeeds([normalizedFeedId]);
+  return { ok: true, message: `Cache revalidated for feed ${normalizedFeedId}` };

Conversation

Alessandro100 commented Mar 25, 2026

Uh oh!

vercel bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Mar 25, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading