Skip to content

feat: display dataset size in table #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alessandro100 merged 2 commits into from
Mar 25, 2026
Merged

feat: display dataset size in table #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c419c61
display dataset size in table
Alessandro100 Mar 24, 2026
d1afc0a
validation report null guard
Alessandro100 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"errors": "errors",
"noErrors": "No errors",
"noWarnings": "No warnings",
"noInfoNotices": "No info notices",
"warnings": "warnings",
"infoNotices": "info notices"
},
Expand Down Expand Up @@ -266,6 +267,8 @@
"datasetHistoryColumns": {
"downloadedAt": "Downloaded At",
"serviceDateRange": "Service Date Range",
"sizeZipped": "Size Zipped (MB)",
"sizeUnzipped": "Size Unzipped (MB)",
"validationReport": "Validation Report",
"actions": "Actions"
},
Expand Down
3 changes: 3 additions & 0 deletions messages/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"errors": "errors",
"noErrors": "No errors",
"noWarnings": "No warnings",
"noInfoNotices": "Aucune notice d'information",
"warnings": "warnings",
"infoNotices": "info notices"
},
Expand Down Expand Up @@ -266,6 +267,8 @@
"datasetHistoryColumns": {
"downloadedAt": "Téléchargé le",
"serviceDateRange": "Plage de dates de service",
"sizeZipped": "Taille compressée (Mo)",
"sizeUnzipped": "Taille décompressée (Mo)",
"validationReport": "Rapport de validation",
"actions": "Actions"
},
Expand Down
35 changes: 24 additions & 11 deletions src/app/screens/Feed/components/DataQualitySummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ export default async function DataQualitySummary({
<>
<Chip
data-testid='error-count'
clickable
clickable={Boolean(latestDataset?.validation_report?.url_html)}
component='a'
href={latestDataset?.validation_report?.url_html}
href={latestDataset?.validation_report?.url_html ?? undefined}
target='_blank'
rel='noopener noreferrer nofollow'
icon={
Expand Down Expand Up @@ -77,9 +77,9 @@ export default async function DataQualitySummary({

<Chip
data-testid='warning-count'
clickable
clickable={Boolean(latestDataset?.validation_report?.url_html)}
component='a'
href={latestDataset?.validation_report?.url_html}
href={latestDataset?.validation_report?.url_html ?? undefined}
target='_blank'
rel='noopener noreferrer nofollow'
icon={
Expand Down Expand Up @@ -112,16 +112,29 @@ export default async function DataQualitySummary({

<Chip
data-testid='info-count'
icon={<InfoOutlinedIcon />}
clickable
icon={
(latestDataset?.validation_report?.unique_info_count ?? 0) >
0 ? (
<InfoOutlinedIcon />
) : (
<CheckCircle />
)
}
clickable={Boolean(latestDataset?.validation_report?.url_html)}
component='a'
href={latestDataset?.validation_report?.url_html}
href={latestDataset?.validation_report?.url_html ?? undefined}
target='_blank'
rel='noopener noreferrer nofollow'
label={`${
latestDataset?.validation_report?.unique_info_count ?? '0'
} ${tCommon('feedback.infoNotices')}`}
color='primary'
label={
(latestDataset?.validation_report?.unique_info_count ?? 0) > 0
? `${latestDataset?.validation_report?.unique_info_count} ${tCommon('feedback.infoNotices')}`
: tCommon('feedback.noInfoNotices')
}
color={
(latestDataset?.validation_report?.unique_info_count ?? 0) > 0
? 'primary'
: 'success'
}
variant='outlined'
/>
</>
Expand Down
Loading
Loading