Skip to content

Refactor empty drawer value relation #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabriel-bolbotina wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor empty drawer value relation #4512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
630e0a9
Changed behaviour of Multi select drawer height if no items are avail…
gabriel-bolbotina May 11, 2026
a174594
Changed full screen policy of mm form value relation editor
gabriel-bolbotina May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/qml/components/MMListMultiselectDrawer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ MMDrawer {

drawerContent: Item {
width: parent.width
height: showFullScreen ? root.drawerContentAvailableHeight : contentLayout.height
height: showFullScreen && listViewComponent.count > 0 ? root.drawerContentAvailableHeight : contentLayout.height

Column {
id: contentLayout

width: parent.width
height: showFullScreen ? parent.height : implicitHeight
height: showFullScreen && listViewComponent.count > 0 ? parent.height : implicitHeight

spacing: 0

Expand Down
2 changes: 1 addition & 1 deletion app/qml/form/editors/MMFormValueRelationEditor.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ MMFormComboboxBaseEditor {

multiSelect: internal.allowMultivalue
withSearch: vrModel.count > 5
showFullScreen: multiSelect || withSearch
showFullScreen: withSearch

valueRole: "FeatureId"
textRole: "FeatureTitle"
Expand Down
Loading