Skip to content

Add messages when variables are not available listings#125

Open
fukuhiro2023 wants to merge 2 commits intomainfrom
124-bug-of-prepare_ae_forestly
Open

Add messages when variables are not available listings#125
fukuhiro2023 wants to merge 2 commits intomainfrom
124-bug-of-prepare_ae_forestly

Conversation

@fukuhiro2023
Copy link
Copy Markdown
Collaborator

@fukuhiro2023 fukuhiro2023 commented Apr 13, 2026

This PR updates prepare_ae_forestly() to:
1. raise an error when the population and observation terms are the same and the variables specified in var for population do not exist in data_observation; and
2. issue a warning when display_ae_listing variables do not exist in data_observation, and display only the variables that do exist in data_observation.

@fukuhiro2023 fukuhiro2023 linked an issue Apr 13, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@wangben718 wangben718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fukuhiro2023
Copy link
Copy Markdown
Collaborator Author

Based on our discussion, I updated prepare_ae_forestly() to merge data_observation and data_population. As a result, the case where the population and observation terms are the same, but variables specified in var for the population do not exist in data_observation, no longer needs to be considered. Therefore, Update 1 above has been replaced. Update 2 remains to handle cases where non-existent variables may be specified in display_ae_listing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug of prepare_ae_forestly

2 participants