Skip to content

<fix>[kvm]: prevent metadata deletion when DVD returns empty #3642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zstack-robot-1 wants to merge 1 commit into
base: 5.5.12
Choose a base branch
from
Open

<fix>[kvm]: prevent metadata deletion when DVD returns empty #3642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions plugin/kvm/src/main/java/org/zstack/kvm/hypervisor/KvmHypervisorInfoManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,15 @@ private boolean saveMetadataList(List<HypervisorMetadataDefinition> definitions)

@Transactional
protected boolean saveHostOsCategoryList(List<HostOsCategoryVO> categoryVOS) {
if (CollectionUtils.isEmpty(categoryVOS)) {
logger.warn("no hypervisor metadata collected from DVD, skip refresh to preserve existing metadata");
return false;
}

// refresh all metadata with current management node
SQL.New(KvmHostHypervisorMetadataVO.class)
.eq(KvmHostHypervisorMetadataVO_.managementNodeUuid, Platform.getManagementServerId())
.delete();
if (CollectionUtils.isEmpty(categoryVOS)) {
return false;
}

Set<String> requestArchitectures = categoryVOS.stream()
.map(HostOsCategoryVO::getArchitecture)
Expand Down