Skip to content

<chore>[cloudbus]: add trace logging for message timeout evaluation #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zstack-robot-2 wants to merge 1 commit into
base: feature-5.5.12-dgpu
Choose a base branch
from
Open

<chore>[cloudbus]: add trace logging for message timeout evaluation #3628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/org/zstack/core/cloudbus/CloudBusImpl3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,9 @@ private MessageReply createTimeoutReply(NeedReplyMessage m) {
public FutureCompletion send(NeedReplyMessage msg, CloudBusCallBack callback) {
evaluateMessageTimeout(msg);
if (msg.getTimeout() <= 1) {
logger.warn(String.format("message timeout too short, rejecting: msg=%s, id=%s, timeout=%d, deadline=%d, serviceId=%s",
msg.getClass().getSimpleName(), msg.getId(), msg.getTimeout(), msg.getMessageDeadline(),
msg.getServiceId()));
callback.run(createTimeoutReply(msg));
return SEND_CONFIRMED;
}
Expand Down
14 changes: 13 additions & 1 deletion core/src/main/java/org/zstack/core/timeout/ApiTimeoutManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,21 @@ public void setMessageTimeout(Message msg) {
} else if (msg instanceof NeedReplyMessage) {
NeedReplyMessage nmsg = (NeedReplyMessage) msg;
if (nmsg.getTimeout() == -1) {
MessageTimeoutDsc mtd = evalTimeout(getMessageTimeout());
long resolvedTimeout = getMessageTimeout();
MessageTimeoutDsc mtd = evalTimeout(resolvedTimeout);
nmsg.setTimeout(mtd.getMessageTimeout());
nmsg.setMessageDeadline(mtd.getMessageDeadline());

if (logger.isTraceEnabled()) {
Map<Object, Object> tc = TaskContext.getTaskContext();
logger.trace(String.format("setMessageTimeout: msg=%s, getMessageTimeout()=%d, " +
"evalResult=[timeout=%d, deadline=%d], taskContext=%s, currentTime=%d, thread=%s",
msg.getClass().getSimpleName(), resolvedTimeout,
mtd.getMessageTimeout(), mtd.getMessageDeadline(),
tc != null ? tc.toString() : "null",
timer.getCurrentTimeMillis(),
Thread.currentThread().getName()));
}
}
}
}
Expand Down