Skip to content

Fix for ESMF link path#1432

Merged
mgduda merged 1 commit intoMPAS-Dev:developfrom
abishekg7:fix_esmf_link_path
Mar 30, 2026
Merged

Fix for ESMF link path#1432
mgduda merged 1 commit intoMPAS-Dev:developfrom
abishekg7:fix_esmf_link_path

Conversation

@abishekg7
Copy link
Copy Markdown
Collaborator

@abishekg7 abishekg7 commented Mar 27, 2026

This PR addresses the linking error that arises when building the MPAS atmosphere core with the nvhpc compiler in DEBUG mode.

The incorrect make variable MPAS_ESMF_LIBS with MPAS_ESMF_LIB, which is the variable defined in the root Makefile.

@abishekg7 abishekg7 changed the base branch from master to develop March 27, 2026 20:43
@abishekg7 abishekg7 changed the title Fix esmf link path Fix for ESMF link path Mar 27, 2026
This commit corrects the link path for the ESMF module by replacing the
incorrect make variable MPAS_ESMF_LIBS with MPAS_ESMF_LIB, which is the
variable defined in the root Makefile.

This issue came to attention due to a linking error that arises when building
the MPAS atmosphere core with the nvhpc compiler in DEBUG mode.
@danrosen25
Copy link
Copy Markdown

@abishekg7 Sorry for the typo! I looked through my work and I think that you caught the only place MPAS_ESMF_LIBS was used. NCAR CISL is working on some CI infrastructure so we'll see less of these mistakes in the future.
66517f6

@mgduda
Copy link
Copy Markdown
Contributor

mgduda commented Mar 30, 2026

@abishekg7 Sorry for the typo! I looked through my work and I think that you caught the only place MPAS_ESMF_LIBS was used. NCAR CISL is working on some CI infrastructure so we'll see less of these mistakes in the future. 66517f6

In principle, I don't think the build_tables executable should even need the ESMF library, but it seems that the NVHPC linker requires the ESMF library when compiling with certain debug options. So the typo in the name of the MPAS_ESMF_LIB variable is something that would probably have only tripped up the NVHPC debug builds, but otherwise doesn't impact the correctness of essentially any other build.

@mgduda mgduda merged commit e411765 into MPAS-Dev:develop Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants