Refactor LogTabWindow and extract logic that is not needed in the GUI#558
Open
Hirogen wants to merge 10 commits intoDevelopmentfrom
Open
Refactor LogTabWindow and extract logic that is not needed in the GUI#558Hirogen wants to merge 10 commits intoDevelopmentfrom
Hirogen wants to merge 10 commits intoDevelopmentfrom
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| ApplyTextResources(); | ||
|
|
||
| Rectangle led = new(0, 0, 8, 2); |
Comment on lines
+93
to
+99
| foreach (var group in HighlightGroups) | ||
| { | ||
| if (group.GroupName.Equals(groupName, StringComparison.Ordinal)) | ||
| { | ||
| return group; | ||
| } | ||
| } |
Comment on lines
+106
to
+122
| foreach (var entry in _configManager.Settings.Preferences.HighlightMaskList) | ||
| { | ||
| if (entry.Mask != null) | ||
| { | ||
| try | ||
| { | ||
| if (Regex.IsMatch(fileName, entry.Mask)) | ||
| { | ||
| return FindHighlightGroupByName(entry.HighlightGroupName); | ||
| } | ||
| } | ||
| catch (ArgumentException e) | ||
| { | ||
| _logger.Error($"RegEx-error while matching highlight mask: {e}"); | ||
| } | ||
| } | ||
| } |
Comment on lines
+139
to
+157
| foreach (var entry in _configManager.Settings.Preferences.ColumnizerMaskList) | ||
| { | ||
| if (entry.Mask != null) | ||
| { | ||
| try | ||
| { | ||
| if (Regex.IsMatch(fileName, entry.Mask)) | ||
| { | ||
| return ColumnizerPicker.FindMemorColumnizerByName( | ||
| entry.ColumnizerName, | ||
| _pluginRegistry.RegisteredColumnizers); | ||
| } | ||
| } | ||
| catch (ArgumentException e) | ||
| { | ||
| _logger.Error($"RegEx-error while finding columnizer: {e}"); | ||
| } | ||
| } | ||
| } |
Comment on lines
+167
to
+173
| foreach (var columnizer in _pluginRegistry.RegisteredColumnizers) | ||
| { | ||
| if (columnizer.GetName().Equals(historyEntry.ColumnizerName, StringComparison.Ordinal)) | ||
| { | ||
| return columnizer; | ||
| } | ||
| } |
Comment on lines
+184
to
+190
| foreach (var entry in _configManager.Settings.ColumnizerHistoryList) | ||
| { | ||
| if (entry.FileName.Equals(fileName, StringComparison.Ordinal)) | ||
| { | ||
| return entry; | ||
| } | ||
| } |
Comment on lines
+207
to
+216
| foreach (var logWindow in _tabController.GetAllWindows()) | ||
| { | ||
| if (logWindow != sender) | ||
| { | ||
| if (logWindow.ScrollToTimestamp(timestamp, false, false)) | ||
| { | ||
| _ledIndicatorService.UpdateWindowActivity(logWindow, DIFF_MAX); | ||
| } | ||
| } | ||
| } |
Comment on lines
+209
to
+215
| if (logWindow != sender) | ||
| { | ||
| if (logWindow.ScrollToTimestamp(timestamp, false, false)) | ||
| { | ||
| _ledIndicatorService.UpdateWindowActivity(logWindow, DIFF_MAX); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the codebase, focusing on enhancing test coverage, refining interface documentation, improving null handling, and updating dependencies. The most significant changes are the addition of comprehensive integration and unit tests for
LogWindowCoordinatorandLogWindow, interface and documentation cleanups, and minor adjustments to test expectations and SDK versions.New and Improved Test Coverage:
LogWindowCoordinatorandLogWindowinLogWindowCoordinatorIntegrationTests, verifying event subscriptions, property delegation, and proper resource cleanup. ([src/LogExpert.Tests/Controls/LogWindowCoordinatorIntegrationTests.csR1-R146])LogWindowCoordinatorinLogWindowCoordinatorTests, covering highlight group resolution, columnizer resolution, shared state, and delegation logic. ([src/LogExpert.Tests/Services/LogWindowCoordinatorTests.csR1-R300])Interface, Documentation, and Usability Improvements:
IContextMenuEntryinterface: improved parameter documentation forGetMenuText, removed obsolete method overloads, and clarified remarks about null handling and parameter expectations. [1]], [2]])ILogWindowinterface by removing a redundant summary and ensuring clarity in method documentation. ([src/LogExpert.Core/Interfaces/ILogWindow.csL150-L164])Bug Fixes and Robustness:
LogfileReaderby ensuring that asynchronous methods returnTask.FromResult<ILogLineMemory>(null)instead ofnull, preventing potential runtime issues. [1]], [2]])CopyFrommethod to theSearchParamsclass for safe copying of search parameters between instances, with null checks. ([src/LogExpert.Core/Entities/SearchParams.csR24-R38])Test Timeout Adjustments:
ProjectFileValidatorTeststo accommodate slower environments and reduce test flakiness. [1]], [2]])Dependency Updates:
global.jsonfrom10.0.100to10.0.200. ([global.jsonL3-R3])Minor Cleanups:
Columnclass. ([src/ColumnizerLib/Column.csL5])These changes collectively improve reliability, maintainability, and test coverage of the codebase.