Fix exception and bad state if save chip is not detected#130
Open
fredemmott wants to merge 1 commit into
Open
Conversation
I have ModRetro Centipede, with a SST39VF1682 and FM28V020-SG; save_chip is `None` with both a Joey Jr and my Chromatic when detecting.
fredemmott
commented
May 9, 2026
|
|
||
| if save_type == 0: | ||
| if "Unknown" in save_chip: | ||
| if save_chip is not None and "Unknown" in save_chip: |
Contributor
Author
There was a problem hiding this comment.
Taking a second look, isn't this whole block inverted?
From the text, it looks like the text below should not be taken for "Unknown"
Perhaps this should be:
if save_chip is None or "Unknown" in save_chip:
msg_save_type_s = "<b>Save Type:</b> None or unknown (no save data detected)<br>"
else
msg_save_type_s = "<b>Save Type:</b> {:s}<br>".format(save_chip)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have ModRetro Centipede, with a SST39VF1682 and FM28V020-SG; save_chip is
Nonewith both a Joey Jr and my Chromatic when detecting.