feat: add report_calls prometheus metric for Report gRPC method#484
feat: add report_calls prometheus metric for Report gRPC method#484RohanKaran wants to merge 1 commit intoKuadrant:mainfrom
Conversation
Add a new Prometheus counter 'report_calls' to track calls to the Report gRPC method introduced in Kuadrant#439. - Register 'report_calls' counter with describe_counter! in PrometheusMetrics - Add incr_report_calls() helper method on PrometheusMetrics - Call incr_report_calls() in KuadrantService::report() after successful counter update, consistent with the existing authorized_calls and limited_calls pattern in ShouldRateLimit Closes Kuadrant#440 Signed-off-by: rohankaran <rohankaran001@gmail.com>
📝 WalkthroughWalkthroughA new Prometheus counter metric ChangesReport Metrics Tracking
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #440
Adds a new
report_callsPrometheus counter to track calls to theReportgRPC method introduced in #439.The new metric follows the same pattern as the existing
authorized_callsandlimited_callscounters:Changes
report_callscounter withdescribe_counter!inPrometheusMetricsincr_report_calls()helper onPrometheusMetricsincr_report_calls()inKuadrantService::report()after a successfulupdate_counterscallprometheus_metrics.rsandkuadrant_service.rsSummary by CodeRabbit
Chores
Tests