Open
Conversation
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=====================================
Coverage 0.38% 0.38%
=====================================
Files 17 17
Lines 783 783
=====================================
Hits 3 3
Misses 780 780 ☔ View full report in Codecov by Sentry. |
Member
|
nice, like this and the approach |
Member
|
I suppose one other option could be a flag to generate a secret, (and an option to pass that secret value in). Not sure which is better really. If this lands, will need to swallow stderr in our CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed value here is that the tools gives you the correct labels and structure of the secret data (the key of the data needs to be
api_key)