Skip to content

Custom form views for Creating/Updating HTTPRoutes#21

Merged
jasonmadigan merged 34 commits intomainfrom
gh-issue-246
Oct 23, 2025
Merged

Custom form views for Creating/Updating HTTPRoutes#21
jasonmadigan merged 34 commits intomainfrom
gh-issue-246

Conversation

@Anton-Fil
Copy link
Copy Markdown
Contributor

@Anton-Fil Anton-Fil commented Aug 20, 2025 •
edited
Loading

closes #12
Verification

In one terminal window, run:

  • yarn install
  • yarn run start

In another terminal window, run:

In browser:

Screenshot 2025-10-22 at 12 43 14
  • press create:
Screenshot 2025-10-22 at 12 45 40 -http rout should be created: Screenshot 2025-10-22 at 12 46 58

Implemented:

  • Form for creating HTTPRoute name
  • Dynamic hostname generation
  • Dynamic Gateway selection with validation
  • Synchronization and switch between YAML editor and form
  • Dynamic creation of rules with smart validation
  • Edit mode
  • UI/UX created by figma design

@Anton-Fil Anton-Fil requested a review from R-Lawton August 20, 2025 15:42
@Anton-Fil
Copy link
Copy Markdown
Contributor Author

Anton-Fil commented Aug 20, 2025

@R-Lawton

@Anton-Fil @R-Lawton
create page with hard coded rules
f914c1a 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil @R-Lawton
add dinamic gateway choose without validation
0ea3fef 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil @R-Lawton
add dinamic validatione to perenRef and UX upgrade
507a543 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil @R-Lawton
Add wizard vith small validatione
9d27720 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil @R-Lawton
create page with hard coded rules
7b2f454 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil @R-Lawton
add dinamic gateway choose without validation
037250b 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil @R-Lawton
add mathces steps+ validation
78e636b 
Signed-off-by: Anton-Fil <afil@redhat.com>
R-Lawton
R-Lawton reviewed Sep 12, 2025
View reviewed changes
Comment thread src/components/httproute/HTTPRouteRuleWizard.tsx Outdated
<TextInput
value={match.pathValue}
onChange={(_, value) => {
value = '/' + value.replace(/^\/+/, '');
Copy link
Copy Markdown
Contributor

@R-Lawton R-Lawton Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For regular expression, it doesn't make sense to have the path as a placeholder in the input field it can cause confusion

Patryk-Stefanski and others added 18 commits September 23, 2025 13:27
@Patryk-Stefanski
Adding filter form to rule wizard
6a4acc7 
Signed-off-by: Patryk Stefanski <pstefans@redhat.com>

Add validation to httprule wizard - filter

Signed-off-by: Patryk Stefanski <pstefans@redhat.com>
@Patryk-Stefanski
fix 'Unexpected any' lint warnings
7f1227e 
Signed-off-by: Patryk Stefanski <pstefans@redhat.com>
@Patryk-Stefanski
fixing up httpRoute edit errors
18def05 
Signed-off-by: Patryk Stefanski <pstefans@redhat.com>
@Patryk-Stefanski
Override default edit button for httpRoutes
2db1382 
Signed-off-by: Patryk Stefanski <pstefans@redhat.com>
@Patryk-Stefanski
Fix form -> yaml synchronization on edit
7bc6652 
Signed-off-by: Patryk Stefanski <pstefans@redhat.com>
@Patryk-Stefanski
Fix create httpRoute yaml view
e34aa98 
Signed-off-by: Patryk Stefanski <pstefans@redhat.com>
@jasonmadigan
Merge pull request #27 from Kuadrant/12-filter-wizard
e6d310b
@Anton-Fil
adding beckand ref + ymal synchronization + validation
2ef9029 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
added select for port, added alert for namespace, fixed bug with chos…
02eac9c 
…ing servise

Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
refractoring
b081d09 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
i18n
93b8ef1 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
refractoring after rewive
2c39e75 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
Merge pull request #29 from Kuadrant/gh-issue-246-backenRef
072b9e0 
Addition of backendRef to the rule wizard for HTTPRoute
@Anton-Fil
review wizart step addet with small validatione
cbd5e00 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
add smart validatione
be911d6 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
add smart validatione+++
6e2b4dc 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
aded smart validation to beckendref
eb4fec3 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
add generic validatione for header nad query param
cd7dd8d 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
refractoring
22b3411 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
upgrade validation
c9d16f4 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
ui upgrade
aea3d01 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
upgrade ui and validation
7098f8c 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
Merge pull request #31 from Kuadrant/gh-issue-246-ReviewAndCreate
e661d8f 
Gh issue 246 review and create wizard step
@Anton-Fil
iu and valifation upgrade
7707a6c 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil
Final interface improvements, validations, and bug fixes
3450ae2 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil Anton-Fil changed the title Gh issue 246 Custom form views for Creating/Updating HTTPRoutes Oct 22, 2025
@Anton-Fil
Final fix filter tab bug
cbe4bce 
Signed-off-by: Anton-Fil <afil@redhat.com>
@Anton-Fil Anton-Fil marked this pull request as ready for review October 22, 2025 11:48
@Anton-Fil
Copy link
Copy Markdown
Contributor Author

Anton-Fil commented Oct 22, 2025

@jasonmadigan
@Patryk-Stefanski

jasonmadigan
jasonmadigan reviewed Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small dupe in console-extensions which we should fixup

otherwise, seems to work pretty good from my local testing

Comment thread src/components/httproute/review/ReviewStep.tsx Outdated
Comment thread console-extensions.json Outdated
@Anton-Fil
Fixed consol extention and restart buttun
3e5fdb4 
Signed-off-by: Anton-Fil <afil@redhat.com>
jasonmadigan
jasonmadigan approved these changes Oct 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonmadigan jasonmadigan merged commit 5878e56 into main Oct 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmadigan jasonmadigan jasonmadigan approved these changes

@Patryk-Stefanski Patryk-Stefanski Awaiting requested review from Patryk-Stefanski

@R-Lawton R-Lawton Awaiting requested review from R-Lawton

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom form views for Creating/Updating HTTPRoutes

4 participants

@Anton-Fil @jasonmadigan @R-Lawton @Patryk-Stefanski