Improve AttributeError message in XmlLayer when accessing missing fields#735
Open
rshayer95 wants to merge 1 commit intoKimiNewt:masterfrom
Open
Improve AttributeError message in XmlLayer when accessing missing fields#735rshayer95 wants to merge 1 commit intoKimiNewt:masterfrom
rshayer95 wants to merge 1 commit intoKimiNewt:masterfrom
Conversation
… fields Raises AttributeError with a helpful message when accessing a non-existent field in XmlLayer. The message includes the field name, layer name, and available fields. Fixes KimiNewt#733
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
AttributeErrorraised inXmlLayer.__getattr__when accessing a non-existent field.Instead of a generic exception, the updated message includes:
This enhancement improves the developer experience by making debugging much easier when interacting with parsed packet data.
File Changed
pyshark/src/pyshark/packet/layers/xml_layer.pyLine 79 Modified