PEM Parsing improvements, unit tests, logging updates#15
Merged
indrora merged 32 commits intorelease-1.0from Apr 30, 2026
Merged
PEM Parsing improvements, unit tests, logging updates#15indrora merged 32 commits intorelease-1.0from
indrora merged 32 commits intorelease-1.0from
Conversation
Contributor
joevanwanzeeleKF
commented
Apr 3, 2026
joevanwanzeeleKF
commented
- Updated the PEM parsing method to be more accepting of a variety of PEM strings
- Added unit testing project
- removed sensitive data from logs and added additional logging
…are-vcenter-orchestrator into pam_support_#79006
updated release action
…are-vcenter-orchestrator into pam_support_#79006
…r than built-in at the config level, for inventory
…e to avoid serialization errors.
…or/vmware-vcenter-orchestrator into pem_parse_updates_#84849
…or/vmware-vcenter-orchestrator into pem_parse_updates_#84849
indrora
added a commit
that referenced
this pull request
Apr 30, 2026
* Added PAM resolution for Server Username and Server Password (#11) Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> * release: 1.0.2 Corrected PAM resolution for Server Username and Server Password (#13) * Added PAM resolution for Server Username and Server Password * Update generated docs * Update generated docs * cleaned up manifest * Create keyfactor-release-workflow.yml updated release action * Delete .github/workflows/keyfactor-starter-workflow.yml * added additional logging for troubleshooting * replaced newtonsoft with system.text.json; additional logging * updated nuget packages * added IPamResolver to job constructors. * fixed issue where logging was called before logger was initialized. * casing username and password to string for PAM resolution.. additional logging. * using the custom fields for server username and server password rather than built-in at the config level, for inventory * Added missing field in ssl cert response model. Marked fields nullable to avoid serialization errors. * added null check and logging for trusted root chain * Updated fields used for PAM username/password resolution * updated changelog * trimming whitespace chars from beginning of trusted root * assigning the trimmed value --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> * PEM Parsing improvements, unit tests, logging updates (#15) * Added PAM resolution for Server Username and Server Password * Update generated docs * Update generated docs * cleaned up manifest * Create keyfactor-release-workflow.yml updated release action * Delete .github/workflows/keyfactor-starter-workflow.yml * added additional logging for troubleshooting * replaced newtonsoft with system.text.json; additional logging * updated nuget packages * added IPamResolver to job constructors. * fixed issue where logging was called before logger was initialized. * casing username and password to string for PAM resolution.. additional logging. * using the custom fields for server username and server password rather than built-in at the config level, for inventory * Added missing field in ssl cert response model. Marked fields nullable to avoid serialization errors. * added null check and logging for trusted root chain * Updated fields used for PAM username/password resolution * updated changelog * trimming whitespace chars from beginning of trusted root * assigning the trimmed value * added unit tests, improved PEM parsing, logging improvements * Update generated docs * updated changelog * removed unnecessary folder from repository * Update generated docs --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io> --------- Co-authored-by: Joe VanWanzeele <76071503+joevanwanzeeleKF@users.noreply.github.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.