Conversation
* added logging and update .net10 * Update generated docs * fixed package vulns * updated documentation * Update generated docs --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
There was a problem hiding this comment.
Pull request overview
This automated merge brings the 2.0.0 release line into main, primarily introducing an Issuer DN-based synchronization scoping feature for multi-CA Idnomic environments, plus substantial logging/diagnostics and framework targeting updates for the Idnomic AnyCA Gateway REST plugin.
Changes:
- Add IssuerDnFilter configuration (field + endpoint-suffix parsing) and apply it during certificate sync/download.
- Introduce FlowLogger and expand structured logging + input validation/error handling across plugin/client operations.
- Update docs/manifest/changelog and add net10.0 to target frameworks (plus new package references).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-manifest.json | Adds IssuerDnFilter to the integration manifest parameters. |
| docsource/idnomic.md | Documents IssuerDnFilter usage, troubleshooting, and adds a dedicated test case. |
| docsource/configuration.md | Mirrors IssuerDnFilter documentation and test case in the general configuration guide. |
| README.md | Updates plugin naming and documents IssuerDnFilter + troubleshooting/test case. |
| Idnomic/IdomicCAPlugin.cs | Enhances logging/validation and wires IssuerDnFilter into client construction. |
| Idnomic/IdnomicPluginConfig.cs | Adds IssuerDnFilter to config constants, model, and annotations. |
| Idnomic/IdnomicClient.cs | Implements endpoint filter parsing, issuer-based filtering, logging improvements, and .NET 10 conditionals. |
| Idnomic/Idnomic.csproj | Adds net10.0 target + additional package references. |
| Idnomic/FlowLogger.cs | New diagnostic helper to emit step/timing “flow” logs at Trace. |
| CHANGELOG.md | Adds a detailed 2.0.0 entry summarizing the above changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| else | ||
| { | ||
| _logger.LogDebug("Disabling IdnomicClient"); | ||
| Client.Disable(); |
| <PackageReference Include="Keyfactor.AnyGateway.IAnyCAPlugin" Version="3.0.0" /> | ||
| <PackageReference Include="Keyfactor.Logging" Version="1.1.1" /> | ||
| <PackageReference Include="Keyfactor.PKI" Version="5.5.0" /> | ||
| <PackageReference Include="System.Drawing.Common" Version="10.0.5" /> |
Comment on lines
+210
to
+214
| public async Task ValidateConnection() | ||
| { | ||
| using var flow = new FlowLogger(_logger, "ValidateConnection"); | ||
| _logger.MethodEntry(LogLevel.Debug); | ||
| EnsureClientIsEnabled(); |
Comment on lines
+143
to
+151
| // Ignore server-side certificate validation entirely (hostname + trust) | ||
| _soapClient.ClientCredentials.ServiceCertificate.SslCertificateAuthentication = | ||
| new System.ServiceModel.Security.X509ServiceCertificateAuthentication | ||
| { | ||
| CertificateValidationMode = System.ServiceModel.Security.X509CertificateValidationMode.None, | ||
| RevocationMode = X509RevocationMode.NoCheck | ||
| }; | ||
|
|
||
| _logger.LogTrace("SOAP client created with client certificate and server validation disabled"); |
Comment on lines
+316
to
+320
| if (!PassesIssuerFilter(certificate.Certificate)) | ||
| { | ||
| filteredCount++; | ||
| continue; | ||
| } |
| if (config.Enabled) | ||
| { | ||
| _logger.LogDebug("Enabling IdnomicClient"); | ||
| Client.Enable(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge release-2.0 to main - Automated PR