Run boiloff in the background through Kerbalism#359
Draft
siimav wants to merge 2 commits into
Draft
Conversation
|
Download the artifacts for this pull request: |
siimav
force-pushed
the
GottaCatchThemAll
branch
from
67eeb82 to
c8f3f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the janky boiloff catchup mechanic with proper background processing.
Relies on getting simulated vessel temperature from Kerbalism (WIP, needs a separate release). Assumes that tank skin temperature is equal to vessel temperature and then calculates the tank internal equilibrium temperature. This will in turn give us the boiloff rate.
Nice to have additions (TODO?):
Also removed the deprecated
loss_ratefeature since all liquids we care about already implementvsp. No point in keeping dead code around.Depends on Kerbalism/Kerbalism#1017