Complete engine config select UI revamp by jackwrichards · Pull Request #355 · KSP-RO/RealFuels

jackwrichards · 2026-02-09T07:49:07Z

Engine config UI overhaul

This PR is a full revamp of the engine configuration selector.

Previously this was just a flat list of configs where you had to hover around, eyeball differences, and dig through other menus to understand what you were actually picking. A lot of important data either wasn’t visible or wasn’t even accessible from this screen.

What’s new

Table-based config view

Replaced the old list with a proper table so all configs can be compared side by side
No more hovering or drilling into sub-menus just to see differences
Columns are fully customizable
Supports both Compact and Full views
Adds several new columns that weren’t previously available from this UI at all

Probability and reliability explained

Added a new “Survival Probability vs Burn Time” section at the bottom
Shows ignition chance and survival probability over time in a clear graph
Makes it obvious what rated vs tested burn time actually means
You can see the probability for any burn duration, not just fixed presets

Built-in simulation tools

UI now explains how reliability data is gained and how engines can fail
Interactive slider lets you simulate any amount of accumulated data
Supports engine clusters so you don’t have to do probability math in your head or on paper anymore

Clear risk messaging

Shows a big, simple “1 in X rated burns will fail” readout
Makes the actual risk explicit instead of something players have to guess at

2026-02-08.23-46-07.mp4

…nality - Updated localization string for current engine configuration to be more concise. - Refactored DrawConfigSelectors method to utilize BuildConfigRows for better structure and clarity in the engine configuration UI. - Enhanced the configuration row definition structure for better data handling and display. - Implemented dynamic column width calculation for the configuration table to improve layout adaptability. - Adjusted GUI styles for the editor panel to enhance visual consistency and usability.

- Implemented GetCurrentFlightData method to retrieve the current flight data for a part. - Implemented GetMaximumData method to retrieve the maximum data value for a part. - Added GetDataPercentage method to calculate the percentage of current data relative to maximum data. - Enhanced reflection logic to safely access TestFlightCore methods.

…ta columns and update visibility logic

… into a dedicated UI folder

…roving tooltip styles

periodically-makes-puns · 2026-02-11T07:07:11Z

Some other issues, which I think are unrelated to the patch bug?

If multiple engines have their UIs open at the same time, z-fighting starts occurring. I don't have a great video of this, but it can be fairly easily reproduced by opening and pinning two different engines, and selecting Show GUI on both of them.
The config entry cost appears to consider unlock credit. I personally find it more useful to ignore unlock credit and show the entry cost directly - otherwise it just shows up as Buy (0) for most configs and that's not really useful when picking between engines/configs.

jackwrichards · 2026-02-11T20:09:58Z

Some other issues, which I think are unrelated to the patch bug?

If multiple engines have their UIs open at the same time, z-fighting starts occurring. I don't have a great video of this, but it can be fairly easily reproduced by opening and pinning two different engines, and selecting Show GUI on both of them.

The config entry cost appears to consider unlock credit. I personally find it more useful to ignore unlock credit and show the entry cost directly - otherwise it just shows up as Buy (0) for most configs and that's not really useful when picking between engines/configs.

The first issue, I will look into, I will probably end up making it so only one may be open at a time.
As for the second issue, I agrtee with you, but I have been getting mixed feedback on that.

…Slider Controls - Set default view to compact mode in EngineConfigGUI. - Introduced slider for burn time with input field and include ignition toggle. - Updated survival probability calculations based on slider time in EngineConfigGUI. - Modified reliability section to display survival probabilities for starting, current, and max data units. - Improved layout and styling for survival probability display in EngineConfigInfoPanel. - Refactored simulation controls to include new slider and checkbox for ignition. - Removed redundant failure rate summary section from EngineConfigInfoPanel.

…ng engine config processing

jackwrichards · 2026-02-12T05:50:54Z

Latest look of the UI

siimav · 2026-02-17T20:57:37Z

+    /// </summary>
+    public static class EngineConfigPropellants
+    {
+        private static readonly FieldInfo MRCSConsumedResources = typeof(ModuleRCS).GetField("consumedResources", BindingFlags.NonPublic | BindingFlags.Instance);


Why reflection when GetConsumedResources() exists?

siimav · 2026-02-17T21:18:25Z

+        public static bool userClosedWindow = false;
+
+        // Track the currently open GUI to ensure only one is visible at a time
+        private static ModuleEngineConfigsBase currentlyOpenGUI = null;


This should get unassigned on leaving editor scene to prevent a :smol: leak

siimav · 2026-02-17T21:38:21Z

+            string[] headers = {
+                "Name", Localizer.GetStringByTag("#RF_EngineRF_Thrust"), "Min%",
+                Localizer.GetStringByTag("#RF_Engine_Isp"), Localizer.GetStringByTag("#RF_Engine_Enginemass"),
+                Localizer.GetStringByTag("#RF_Engine_TLTInfo_Gimbal"), Localizer.GetStringByTag("#RF_EngineRF_Ignitions"),
+                Localizer.GetStringByTag("#RF_Engine_ullage"), Localizer.GetStringByTag("#RF_Engine_pressureFed"),
+                "Rated (s)", "Tested (s)", "Ign Reliability", "Burn No Data", "Burn Max Data",
+                "Survival @ Time",
+                Localizer.GetStringByTag("#RF_Engine_Requires"), "Extra Cost", ""
+            };
+            string[] tooltips = {
+                "Configuration name", "Rated thrust", "Minimum throttle",
+                "Sea level and vacuum Isp", "Engine mass", "Gimbal range", "Ignitions",
+                "Ullage requirement", "Pressure-fed", "Rated burn time",
+                "Tested burn time (real-world test duration)",
+                "Ignition reliability (starting / max data)",
+                "Cycle reliability at 0 data", "Cycle reliability at max data",
+                "Survival probability at slider time (starting / max data)",
+                "Required technology", "Extra cost for this config", "Switch and purchase actions"
+            };


Should move all the rest to loc file too. Weird if some are there and others aren't.

siimav · 2026-02-17T21:41:11Z

+            int visibleRows = Mathf.Min(actualRows, ConfigMaxVisibleRows);
+            int scrollViewHeight = visibleRows * ConfigRowHeight;
+
+            var scrollStyle = new GUIStyle(GUI.skin.scrollView) { padding = new RectOffset(0, 0, 0, 0) };


Unwise to allocate new styles twice per frame.

siimav · 2026-02-17T21:52:41Z

+        internal string GetTechString(ConfigNode node)
+        {
+            if (!node.HasValue("techRequired"))
+                return "-";
+
+            string tech = node.GetValue("techRequired");
+            if (ModuleEngineConfigsBase.techNameToTitle.TryGetValue(tech, out string title))
+                tech = title;
+
+            var words = tech.Split(' ');
+            if (words.Length <= 1)
+                return tech;
+
+            var abbreviated = words[0];
+            for (int i = 1; i < words.Length; i++)
+            {
+                if (words[i].Length > 4)
+                    abbreviated += "-" + words[i].Substring(0, 4);
+                else
+                    abbreviated += "-" + words[i];
+            }
+            return abbreviated;
+        }


Never mind about allocating gui styles. This is a lot worse!
I wonder if we could show only the year number here. Or perhaps just make the text smaller? Make it wrap?

siimav · 2026-02-17T22:02:05Z

+
+        #endregion
+
+        #region RP-1 Credit Integration


Should extract such integrations into a separate file.

siimav · 2026-02-17T22:05:12Z

+            string[] failureTypes = { "Shutdown", "Perf. Loss", "Reduced Thrust", "Explode" };
+            int[] failureDu = { 1000, 800, 700, 1000 };
+            float[] failurePercents = { 55.2f, 27.6f, 13.8f, 3.4f };


Probably not the best to hardcode all the TF values. Some of those might be subject to change.

periodically-makes-puns · 2026-02-19T21:07:54Z

The configuration menu sometimes doesn't show up when selecting parts with symmetry. It's a bit weird to reproduce but you should run into it fairly quickly if you try reconfiguring a set of RCS thrusters and a cluster of engines a bunch. I suspect it has something to do with how the Hide GUI toggle is handled across symmetric parts.

periodically-makes-puns · 2026-02-27T06:38:40Z

+                    if (propNode.TryGetValue("ratio", ref ratioStr2) && float.TryParse(ratioStr2, out float ratio) && totalMassFlow > 0f && totalRatio > 0f)
+                    {
+                        float propMassFlow = totalMassFlow * (ratio / totalRatio);


The ratio parameter on engines is a ratio of volumes, not masses. The kg/s consumption values in the screenshot are actually the L/s consumption values.

- Introduced a toggle for switching between percentage and time modes for survival probability calculations. - Updated the EngineConfigGUI to handle new slider inputs for percentage and time, ensuring values persist across engines. - Modified the reliability section to display survival probabilities based on the selected mode, adjusting calculations accordingly. - Enhanced the UI to reflect changes in survival probability display, including dynamic headers and tooltips. - Updated the simulation controls to accommodate the new mode, allowing users to input either a survival percentage or a burn time.

Clayell · 2026-03-21T03:08:51Z

Unsure if I just compiled it badly, but this seems to be not working exactly right.

(it also just completely doesn't show on the r103, an SRB)

Yes, Siimav told me that the proper way to handle this was to do it through the original PR, but I REALLY didn't want to go through the process of disentangling this. * Added ClickThroughBlocker * Added a Settings option to have the Engine GUI always open when engine is clicked on * Moved the TestFlight failures into an external file so they can easily be updated if TF ever changes them * Fixed the RCS Graphs attempting to open even without TF failures attached to them * Fixed the propellant consumption math * Removed the reflection to get the RCS propellants and used GetConsumedResources() instead * Cached the GUIStyle allocations as static properties to stop the extra calls per frame * Fixed the issue where engines in symmetry were failing to open the window. The previous design was only trying to access the "first" engine that was placed * Removed the tech abbreviations * Moved the remaining items into localization * Extracted the RP-1 credit information into a separate file

* Refactor engine configuration UI for improved readability and functionality - Updated localization string for current engine configuration to be more concise. - Refactored DrawConfigSelectors method to utilize BuildConfigRows for better structure and clarity in the engine configuration UI. - Enhanced the configuration row definition structure for better data handling and display. - Implemented dynamic column width calculation for the configuration table to improve layout adaptability. - Adjusted GUI styles for the editor panel to enhance visual consistency and usability. * Add TestFlight data retrieval methods to TestFlightWrapper - Implemented GetCurrentFlightData method to retrieve the current flight data for a part. - Implemented GetMaximumData method to retrieve the maximum data value for a part. - Added GetDataPercentage method to calculate the percentage of current data relative to maximum data. - Enhanced reflection logic to safely access TestFlightCore methods. * Implement feature X to enhance user experience and optimize performance * Implement feature X to enhance user experience and fix bug Y in module Z * Refactor column management in ModuleEngineConfigs to remove unused data columns and update visibility logic * Refactor code structure * Even more reorganization of the engine config UI code. * Reorganize engine config UI code structure by moving UI-related files into a dedicated UI folder * Enhance engine configuration UI by adding close functionality and improving tooltip styles * MM Patch fix, and other fixes * feat: Enhance Engine Configuration GUI with Survival Probability and Slider Controls - Set default view to compact mode in EngineConfigGUI. - Introduced slider for burn time with input field and include ignition toggle. - Updated survival probability calculations based on slider time in EngineConfigGUI. - Modified reliability section to display survival probabilities for starting, current, and max data units. - Improved layout and styling for survival probability display in EngineConfigInfoPanel. - Refactored simulation controls to include new slider and checkbox for ignition. - Removed redundant failure rate summary section from EngineConfigInfoPanel. * refactor: Simplify TestFlight UI support configuration by consolidating engine config processing * Enhance Engine Configuration GUI with Survival Probability Modes - Introduced a toggle for switching between percentage and time modes for survival probability calculations. - Updated the EngineConfigGUI to handle new slider inputs for percentage and time, ensuring values persist across engines. - Modified the reliability section to display survival probabilities based on the selected mode, adjusting calculations accordingly. - Enhanced the UI to reflect changes in survival probability display, including dynamic headers and tooltips. - Updated the simulation controls to accommodate the new mode, allowing users to input either a survival percentage or a burn time. * Introduce new RealFuels tank configuration window Replaces the legacy TankWindow with a modernized UI overhaul (RealFuelsWindow). This includes a new Life Support planner, quick-fill engine presets with ratio status indicators, resource locking, and a searchable available propellants list. The project target framework is also updated to v4.8 to support the new UI components. * Improve the Layout and Design of the new Tank UI Window * Fix issues from PR #355 Yes, Siimav told me that the proper way to handle this was to do it through the original PR, but I REALLY didn't want to go through the process of disentangling this. * Added ClickThroughBlocker * Added a Settings option to have the Engine GUI always open when engine is clicked on * Moved the TestFlight failures into an external file so they can easily be updated if TF ever changes them * Fixed the RCS Graphs attempting to open even without TF failures attached to them * Fixed the propellant consumption math * Removed the reflection to get the RCS propellants and used GetConsumedResources() instead * Cached the GUIStyle allocations as static properties to stop the extra calls per frame * Fixed the issue where engines in symmetry were failing to open the window. The previous design was only trying to access the "first" engine that was placed * Removed the tech abbreviations * Moved the remaining items into localization * Extracted the RP-1 credit information into a separate file * Final UI Updates * Added MUCH better RCS / Generic Engine UI to help trigger players to upgrade their RCS levels. * Fixed an issue where the Tank UI wouldn't work properly on symmetry items * Fixed the issue where locking a resource did not persist when the UI closed * Allow direct selection of Liters when adding a new resource to a tank * Changed the QUICK FILL section to treat the entire row as a button * Removed the legacy TankWindow.cs and removed the never used RealWindowsPAW code. --------- Co-authored-by: Arodoid <ockidj@gmail.com>

Clayell · 2026-05-12T20:29:16Z

#360 supersedes this right? If so, this can probably be closed.

pap1723 · 2026-05-12T20:32:46Z

Merged into UIOverhaul branch and released.

jackwrichards added 10 commits February 6, 2026 23:20

Implement feature X to enhance user experience and optimize performance

783732c

Implement feature X to enhance user experience and fix bug Y in module Z

70d25b3

Refactor column management in ModuleEngineConfigs to remove unused da…

6c3ea71

…ta columns and update visibility logic

Refactor code structure

252c276

Even more reorganization of the engine config UI code.

4b0952f

Reorganize engine config UI code structure by moving UI-related files…

9ff0dd2

… into a dedicated UI folder

Enhance engine configuration UI by adding close functionality and imp…

9393ec0

…roving tooltip styles

MM Patch fix, and other fixes

52be443

periodically-makes-puns reviewed Feb 11, 2026

View reviewed changes

Comment thread RealFuels/RF_TestFlight_UISupport.cfg Outdated

periodically-makes-puns reviewed Feb 11, 2026

View reviewed changes

Comment thread RealFuels/RF_TestFlight_UISupport.cfg Outdated

jackwrichards added 2 commits February 11, 2026 21:34

refactor: Simplify TestFlight UI support configuration by consolidati…

c55e242

…ng engine config processing

siimav requested changes Feb 17, 2026

View reviewed changes

periodically-makes-puns reviewed Feb 27, 2026

View reviewed changes

pap1723 closed this May 12, 2026

Conversation

jackwrichards commented Feb 9, 2026

Engine config UI overhaul

What’s new

Uh oh!

Uh oh!

Uh oh!

periodically-makes-puns commented Feb 11, 2026

Uh oh!

jackwrichards commented Feb 11, 2026

Uh oh!

jackwrichards commented Feb 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

periodically-makes-puns commented Feb 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Clayell commented Mar 21, 2026

Uh oh!

Clayell commented May 12, 2026

Uh oh!

pap1723 commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants