Skip to content

Remove unused globals from libcamera example#10

Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
KSP-KOS:masterfrom
Sean-Kenneth-Doherty:fix-libcamera-unused-globals
Closed

Remove unused globals from libcamera example#10
Sean-Kenneth-Doherty wants to merge 1 commit into
KSP-KOS:masterfrom
Sean-Kenneth-Doherty:fix-libcamera-unused-globals

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • Remove two unused globals from Example Scripts/libcamera.ks.
  • Avoid evaluating the undefined pi name during library initialization.

Fixes #2.

Validation

  • git diff --check
  • rg -n "libcamera_doGeo|libcamera_degToRad|\bpi\b" "Example Scripts/libcamera.ks" returned no matches.
  • Build was attempted, but this checkout has no configured KSP game instance, so CKAN stopped before compile.

@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Closing this under my tightened quality bar rather than leaving an unproven kOS example-script draft in your queue. The branch fixes a plausible undefined-global startup path with targeted static checks, but the build did not complete locally and the script was not runtime-tested in KSP/kOS. I will not reopen unless you want this exact fix or there is a concrete user-facing defect with proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused global variables throwing errors in the terminal

1 participant