[ENHANCEMENT] Rework Plugins to Use Capabilities and Modules#260
Draft
menvae wants to merge 9 commits into
Draft
[ENHANCEMENT] Rework Plugins to Use Capabilities and Modules#260menvae wants to merge 9 commits into
menvae wants to merge 9 commits into
Conversation
+ fix duplicate loading in plugins + add logger for plugins
note: the translation string is now unused (fluXis.Localization.Categories.Settings.SettingsPluginsStrings.ImportPlugins)
menvae
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Plugins now implement their functionality through capabilities instead of being hardcoded to map importers.
Also implemented modules for plugins which can have capabilities too instead of having all implementation in
Plugin.Made plugin settings have sub sections.
Note: the translation string is now unused (fluXis.Localization.Categories.Settings.SettingsPluginsStrings.ImportPlugins) because we use enums for the plugin type name