Skip to content

moxa iologik: Avoid covering displayed values with disconnection errrors in OPI#961

Open
FreddieAkeroyd wants to merge 1 commit intomasterfrom
iologik_show_unaliased_ports
Open

moxa iologik: Avoid covering displayed values with disconnection errrors in OPI#961
FreddieAkeroyd wants to merge 1 commit intomasterfrom
iologik_show_unaliased_ports

Conversation

@FreddieAkeroyd
Copy link
Copy Markdown
Member

Description of work

show unaliased values

To test

check all values show in OPI

Acceptance criteria

List the acceptance criteria for the PR

  • ** If this PR changes GALIL / GALILMUL ioc are these changes applicable to both the old (galil-old branch based) and new (master branch based) drivers? If so have all appropriate PRs been created **

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks May 5, 2026
@FreddieAkeroyd FreddieAkeroyd changed the title Show unaliased values moxa iologik: Show unaliased values in OPI May 5, 2026
@Tom-Willemsen
Copy link
Copy Markdown
Member

Tom-Willemsen commented May 7, 2026

Looking at the original PRs, this functionality (hiding unaliased PVs) was explicitly included. I guess it was so that people didn't see lots of irrelevant/confusing inputs in the OPI if they were only using one or two of them.

I'm not convinced we want this change?

If we do want this change, we need:

  • A corresponding change in the OPI side to remove the now-redundant rules/scripts.
  • Release notes as this is user facing

@FreddieAkeroyd
Copy link
Copy Markdown
Member Author

FreddieAkeroyd commented May 7, 2026

What i was trying to avoiding was the rather horrible mess of disconnected boxes that seemed to get left when aliases were not added, i think the STAT pv used by the OPI only existed if the PV was aliased. Maybe we can show a value greyed out if it is unaliased? Of if we prefer to hide them, keep db changes other than the ones for moxa12XX_aliases.db so at least we get the PVs the OPI is expecting defined at all times even if not displayed

@Tom-Willemsen
Copy link
Copy Markdown
Member

Maybe we can show a value greyed out if it is unaliased? Of if we prefer to hide them, keep db changes other than the ones for moxa12XX_aliases.db so at least we get the PVs the OPI is expecting defined at all times even if not displayed

That sounds reasonable to me.

@FreddieAkeroyd
Copy link
Copy Markdown
Member Author

The greying out would need an OPI change, the other probably not. At this stage should we just make the PVs available but hidden, which gets round one problem where the disconnected errors actually blocked out what you had tried to make visible by aliases

@FreddieAkeroyd FreddieAkeroyd force-pushed the iologik_show_unaliased_ports branch from 3c30f16 to ba86862 Compare May 8, 2026 14:10
@FreddieAkeroyd FreddieAkeroyd force-pushed the iologik_show_unaliased_ports branch from ba86862 to e23a5cc Compare May 8, 2026 14:15
@FreddieAkeroyd FreddieAkeroyd changed the title moxa iologik: Show unaliased values in OPI moxa iologik: Avoid covering displayed values with disconnection errrors in OPI May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Flash Review

Development

Successfully merging this pull request may close these issues.

2 participants