Skip to content

Fix Publish and Submit for Review when no files are present in Dataset#12266

Open
stevenwinship wants to merge 5 commits intodevelopfrom
12258-publish-submit-contains-files
Open

Fix Publish and Submit for Review when no files are present in Dataset#12266
stevenwinship wants to merge 5 commits intodevelopfrom
12258-publish-submit-contains-files

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

@stevenwinship stevenwinship commented Mar 30, 2026

What this PR does / why we need it:
Per #10981 a dataset should not be publishable if it contains no files. This issue should check the number of files in the Dataset version and not the total number of files in the dataset.
This is only an issue when the attribute 'requireFilesToPublishDataset' is set

Which issue(s) this PR closes:#12258

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Submit for review button on JSF UI Dataset Page will be hidden if no files are contained in the Dataset Version

requireFilesToPublishDataset set to true
image

requireFilesToPublishDataset set to false
image

Is there a release notes update needed for this change?: Included

Additional documentation: changelog

@github-actions github-actions Bot added FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect labels Mar 30, 2026
@stevenwinship stevenwinship self-assigned this Mar 30, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Mar 30, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 30, 2026

Coverage Status

coverage: 24.874% (+0.001%) from 24.873% — 12258-publish-submit-contains-files into develop

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Mar 30, 2026
@stevenwinship stevenwinship removed their assignment Mar 30, 2026
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 12258-publish-submit-contains-files branch from 8a2ea18 to 9b1b478 Compare April 2, 2026 13:32
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) label Apr 8, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@stevenwinship stevenwinship added this to the 6.11 milestone Apr 20, 2026
@landreev landreev self-assigned this Apr 20, 2026
@landreev landreev self-requested a review April 20, 2026 15:50
@landreev landreev moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 20, 2026
Copy link
Copy Markdown
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but the code looks good.

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 20, 2026
@github-actions
Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12258-publish-submit-contains-files
ghcr.io/gdcc/configbaker:12258-publish-submit-contains-files

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@sekmiller
Copy link
Copy Markdown
Contributor

sekmiller commented Apr 21, 2026

Getting a weird result here. If I'm logged in as a superuser and the dataset has no files, but is required to at the collection level there's a banner for "You must submit for Review", but there's no submit button (and there shouldn't be a button because the super user should be able to publish?). Nor is there a Publish button.

This also happens to non-superusers with publish dataset privileges. If the collection requires files and they are not present the "Submit for Review" banner is displayed - but there's no Submit button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect

Projects

Status: QA ✅

Development

Successfully merging this pull request may close these issues.

Publishing: Published dataset version should contain files

5 participants