Open
Conversation
andreyorst
force-pushed
the
de-identification
branch
from
0b8bbd6 to
3bc576a
Compare
andreyorst
force-pushed
the
de-identification
branch
from
3bc576a to
d548ba8
Compare
andreyorst
force-pushed
the
de-identification
branch
from
d548ba8 to
12dfe32
Compare
aleksandrkislitsyn
requested changes
Apr 16, 2026
andreyorst
force-pushed
the
de-identification
branch
from
0f330d8 to
8df284c
Compare
andreyorst
force-pushed
the
de-identification
branch
from
8df284c to
0bafbc8
Compare
|
|
||
| A ViewDefinition that contains any de-identification extension can only be materialized as a `table`. Attempting to materialize as `view` or `materialized-view` returns HTTP 422 with an OperationOutcome: | ||
|
|
||
| > ViewDefinitions with de-identification extensions can only be materialized as 'table'. Views and materialized views expose cryptographic keys in PostgreSQL system catalogs. |
Collaborator
There was a problem hiding this comment.
I think we can remove this line because the next sentence already explains the restriction
|
|
||
| ## Pre-built ViewDefinitions | ||
|
|
||
| The IG package `io.health-samurai.de-identification.r4` provides ready-made Safe Harbor ViewDefinitions for common FHIR R4 resource types. Install it via FAR (Aidbox's artifact registry): |
Collaborator
There was a problem hiding this comment.
How to do it? Can't find it. Can you specify it here?
|
|
||
| ## Pre-built ViewDefinitions | ||
|
|
||
| The IG package `io.health-samurai.de-identification.r4` provides ready-made Safe Harbor ViewDefinitions for common FHIR R4 resource types. Install it via FAR (Aidbox's artifact registry): |
Collaborator
There was a problem hiding this comment.
FAR is not used widely in docs, and in UI, it is not FAR anymore.
"via FAR (Aidbox's artifact registry)" -> "via [Artefact Registry](relative-path/artifact-registry/artifact-registry-overview) ("FHIR packages" in Aidbox UI)"
| ``` | ||
|
|
||
| This example uses the built-in PostgreSQL `left` function to keep only the first 4 characters (e.g. extracting just the year from a date string). | ||
|
|
Collaborator
There was a problem hiding this comment.
add here "See also: [Writing custom PostgreSQL functions](#writing-custom-postgresql-functions)"
|
|
||
| Restrict access to ViewDefinition resources using [AccessPolicy](../../access-control/authorization/README.md) to ensure only authorized users can view or modify de-identification configurations. | ||
|
|
||
| ### SQL injection prevention |
Collaborator
There was a problem hiding this comment.
We didn't write about SQL injection prevention in the docs before. It is cool that we do it, but we don't have to point to it. Maybe it's just me, but I think it is redundant here.
| } | ||
| ``` | ||
|
|
||
| ## Security considerations |
Collaborator
There was a problem hiding this comment.
Not much here. We can split "key management" and "encryption limitations" content into hints in "## encrypt" section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.