feat: 拖拽版本 json 安装实例 by CiiLu · Pull Request #5730 · HMCL-dev/HMCL

CiiLu · 2026-03-07T14:39:16Z

resolves #5459

Copilot

Pull request overview

Adds support for creating/installing a game instance by dragging a Minecraft version-manifest-style JSON into the launcher, addressing feature request #5459 (install unlisted/ancient/third-party versions without manual folder setup).

Changes:

Add i18n strings for “malformed instance JSON”.
Add Versions.installFromJson(Profile, Path) to parse a version JSON, write it into <gameDir>/versions/<id>/<id>.json, and trigger game jar download.
Extend drag-and-drop handlers (Root page + Game list page) to accept JSON files and invoke the new installer.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties	Adds zh_CN error message for invalid instance JSON.
HMCL/src/main/resources/assets/lang/I18N_zh.properties	Adds zh_TW error message for invalid instance JSON.
HMCL/src/main/resources/assets/lang/I18N.properties	Adds English error message for invalid instance JSON.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/Versions.java	Implements JSON-based instance installation + download flow.
HMCL/src/main/java/org/jackhuang/hmcl/ui/main/RootPage.java	Allows dragging `.json` into main page to trigger install.
HMCL/src/main/java/org/jackhuang/hmcl/ui/Controllers.java	Allows dragging files into game list page to trigger install.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCL/src/main/java/org/jackhuang/hmcl/ui/Controllers.java

-        FXUtils.applyDragListener(gameListPage, ModpackHelper::isFileModpackByExtension, modpacks -> {
-            Path modpack = modpacks.get(0);
-            Controllers.getDecorator().startWizard(new ModpackInstallWizardProvider(Profiles.getSelectedProfile(), modpack), i18n("install.modpack"));
+        FXUtils.applyDragListener(gameListPage, file -> ModpackHelper.isFileModpackByExtension(file) || "json".equalsIgnoreCase(FileUtils.getNameWithoutExtension(file)), files -> {


HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/Versions.java

+                    profile.getRepository().refreshVersions();
+                    profile.setSelectedVersion(result);
+                    handler.resolve();


HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/Versions.java

+            });
+            Task.runAsync(() -> {
+                var dir = profile.getGameDir().resolve("versions");
+                var versionDir = Files.createDirectory(dir.resolve(result));


HMCL/src/main/resources/assets/lang/I18N.properties

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Glavo · 2026-03-27T12:27:24Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/Versions.java

+                    handler.resolve();
+                }
+            });
+            Task.runAsync(() -> {


这是在干什么？为什么要启动两个 Task？

…rror handling

… tasks

…formatting

Copilot

Pull request overview

This PR adds support for installing a Minecraft instance by dragging a client/version JSON file into the launcher UI (resolving #5459), integrating the flow into existing drag-and-drop entry points and adding the needed i18n strings.

Changes:

Add a new Versions.installFromJson(Profile, Path) flow that parses a version JSON, prompts for a target instance name, downloads required game components, and saves the instance.
Extend drag-and-drop handlers on main UI pages to accept .json files and trigger JSON-based installation.
Add new localized strings for “malformed JSON” errors across I18N.properties variants.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
HMCL/src/main/resources/assets/lang/I18N.properties	Adds English error string for invalid instance JSON.
HMCL/src/main/resources/assets/lang/I18N_zh.properties	Adds Traditional Chinese error string for invalid instance JSON.
HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties	Adds Simplified Chinese error string for invalid instance JSON.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/Versions.java	Introduces `installFromJson` implementation and wires it into the install task pipeline.
HMCL/src/main/java/org/jackhuang/hmcl/ui/main/RootPage.java	Extends main page drag-and-drop to accept JSON and call `installFromJson`.
HMCL/src/main/java/org/jackhuang/hmcl/ui/Controllers.java	Extends game list page drag-and-drop to accept JSON and call `installFromJson` (but currently has a filter bug).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T13:20:15Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/Controllers.java

-        FXUtils.applyDragListener(gameListPage, ModpackHelper::isFileModpackByExtension, modpacks -> {
-            Path modpack = modpacks.get(0);
-            Controllers.getDecorator().startWizard(new ModpackInstallWizardProvider(Profiles.getSelectedProfile(), modpack), i18n("install.modpack"));
+        FXUtils.applyDragListener(gameListPage, file -> ModpackHelper.isFileModpackByExtension(file) || "json".equalsIgnoreCase(FileUtils.getNameWithoutExtension(file)), files -> {


Drag-and-drop filter for the GameListPage checks "json".equalsIgnoreCase(FileUtils.getNameWithoutExtension(file)), which will never match normal files like something.json (nameWithoutExtension would be something). As a result, JSON files won’t be accepted for drag/drop here even though the handler supports them. Use FileUtils.getExtension(file) (consistent with the handler) to detect JSON files.

Suggested change

FXUtils.applyDragListener(gameListPage, file -> ModpackHelper.isFileModpackByExtension(file) || "json".equalsIgnoreCase(FileUtils.getNameWithoutExtension(file)), files -> {

FXUtils.applyDragListener(gameListPage, file -> ModpackHelper.isFileModpackByExtension(file) || "json".equalsIgnoreCase(FileUtils.getExtension(file)), files -> {

Copilot · 2026-04-01T13:20:15Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/Versions.java

+            Version newVersion = version.setId(result).setJar(result);
+


installFromJson renames the parsed version by doing version.setId(result).setJar(result). For version JSONs that use inheritsFrom (common in modded/third-party manifests) or that omit explicit downloads.client.url, forcing jar to the new instance id can override the parent jar selection and/or cause the default download URL to be computed from the renamed id, breaking jar resolution/download. Prefer preserving the original jar semantics (and only normalizing away the “jar == old id” case) rather than always setting jar to the new id.

Suggested change

Version newVersion = version.setId(result).setJar(result);

String oldId = version.getId();

String oldJar = version.getJar();

Version newVersion = version.setId(result);

if (oldJar == null || oldJar.equals(oldId)) {

newVersion = newVersion.setJar(result);

}

CiiLu added 2 commits March 7, 2026 21:20

update

e8e8b33

update

78e3152

Glavo requested a review from Copilot March 13, 2026 14:08

Copilot started reviewing on behalf of Glavo March 13, 2026 14:09 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

CiiLu changed the title ~~Support installing instance from version manifest json~~ feat: 拖拽版本 json 安装实例 Mar 13, 2026

Potential fix for pull request finding

6cc68fd

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Glavo reviewed Mar 27, 2026

View reviewed changes

Glavo added 4 commits March 30, 2026 21:37

Merge remote-tracking branch 'upstream/main' into json

8ae50ce

Refactor version management logic for improved code readability and e…

77b4a13

…rror handling

Improve version duplication flow by adding asset and library download…

c211f21

… tasks

Remove unused JsonUtils import and clean up renameVersion method …

02c0dfd

…formatting

Glavo requested a review from Copilot April 1, 2026 13:14

Copilot started reviewing on behalf of Glavo April 1, 2026 13:15 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 拖拽版本 json 安装实例#5730

feat: 拖拽版本 json 安装实例#5730
CiiLu wants to merge 7 commits intoHMCL-dev:mainfrom
CiiLu:json

CiiLu commented Mar 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Glavo Mar 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	FXUtils.applyDragListener(gameListPage, file -> ModpackHelper.isFileModpackByExtension(file) \|\| "json".equalsIgnoreCase(FileUtils.getNameWithoutExtension(file)), files -> {
	FXUtils.applyDragListener(gameListPage, file -> ModpackHelper.isFileModpackByExtension(file) \|\| "json".equalsIgnoreCase(FileUtils.getExtension(file)), files -> {

-            Version newVersion = version.setId(result).setJar(result);
+            String oldId = version.getId();
+            String oldJar = version.getJar();
+            Version newVersion = version.setId(result);
+            if (oldJar == null || oldJar.equals(oldId)) {
+                newVersion = newVersion.setJar(result);
+            }

Conversation

CiiLu commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Glavo Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CiiLu commented Mar 7, 2026 •

edited

Loading