Skip to content

Add support for 8 bit wav files #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThunderClapLP wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for 8 bit wav files #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions GDScriptAudioImport.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func loadfile(filepath):

var data = bytes.subarray(data_entry_point, data_entry_point+audio_data_size-1)

if bits_per_sample in [24, 32]:
if bits_per_sample in [8, 24, 32]:
newstream.data = convert_to_16bit(data, bits_per_sample)
else:
newstream.data = data
Expand Down Expand Up @@ -171,7 +171,7 @@ func loadfile(filepath):
print ("ERROR: Wrong filetype or format")
file.close()

# Converts .wav data from 24 or 32 bits to 16
# Converts .wav data from 8, 24 or 32 bits to 16
#
# These conversions are SLOW in GDScript
# on my one test song, 32 -> 16 was around 3x slower than 24 -> 16
Expand All @@ -184,6 +184,13 @@ func loadfile(filepath):
func convert_to_16bit(data: PoolByteArray, from: int) -> PoolByteArray:
print("converting to 16-bit from %d" % from)
var time = OS.get_ticks_msec()
#8 bit so we just scale it into two bytes:
if from == 8:
var spb := StreamPeerBuffer.new()
spb.resize(data.size() * 2)
for i in range(0, data.size(), 1):
spb.put_16((data[i] * 65535) / 255 - 32768)
return spb.data_array
# 24 bit .wav's are typically stored as integers
# so we just grab the 2 most significant bytes and ignore the other
if from == 24:
Expand Down