feat(vue): add loading and error slots to FormRelay component#9
Merged
Conversation
Add optional #loading and #error named slots so consumers can show placeholder content while the schema fetches and handle fetch failures without manual v-if checks on schemaLoading/schemaError. Fully backwards compatible — omitting the slots preserves existing default-slot-only behavior.
Use fixed versioning so all @formrelay/* packages stay at the same version without needing to list unchanged packages in changesets. Also remove core from the changeset since fixed handles it automatically.
Ensure error slot takes priority over loading slot if both states are truthy simultaneously. Also adds tests for loading-to-error transition, FormRelayError pass-through, and no-slots rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#loadingand#errornamed slots to the<FormRelay>component#loadingrenders while the schema is being fetched — prevents showing an empty form with a visible submit button#errorrenders when the schema fetch fails, with{ error }as slot propsschemaLoading/schemaErrorstill passed as props)Usage
Test plan
schemaLoading: true) when no loading slot providedschemaError) when no error slot provided