Skip to content

fix(ci): remove broken npm self-install and remediate CVEs #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbas21 merged 2 commits into from
Apr 14, 2026
+179 −120
Merged

fix(ci): remove broken npm self-install and remediate CVEs #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
119386b
fix(ci): remove broken npm self-install and remediate CVEs
ryanbas21 Apr 9, 2026
13b0ee2
fix(ci): remove path-to-regexp override that broke Express and MSW
ryanbas21 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ jobs:
with:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- run: npm install npm@latest -g
- run: npm --version

Comment on lines -54 to -56
Copy link
Copy Markdown
Collaborator

@ancheetah ancheetah Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the corepack install? Thought that was the fix at some point?

Copy link
Copy Markdown
Collaborator Author

@ryanbas21 ryanbas21 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i only did it in the PR flow not the publish one.

Copy link
Copy Markdown
Collaborator

@ancheetah ancheetah Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving. we already update npm to latest in the setup action

- name: publish
uses: changesets/action@v1
id: changesets
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@
"pnpm": {
"overrides": {
"rollup": "^4.59.0",
"undici@^7": "^7.24.0"
"undici@^7": "^7.24.0",
"picomatch@>=4": "^4.0.4",
"picomatch@<3": "^2.3.2"
}
}
}
Loading
Loading