Skip to content

SDKS-4669: Add support for phone number extensions in PhoneNumberCollector#177

Merged
spetrov merged 1 commit intodevelopfrom
SDKS-4669
Apr 15, 2026
Merged

SDKS-4669: Add support for phone number extensions in PhoneNumberCollector#177
spetrov merged 1 commit intodevelopfrom
SDKS-4669

Conversation

@vibhorgoswami
Copy link
Copy Markdown
Contributor

JIRA Ticket

SDKS-4669

Description

This PR adds support for the phone number extension field. It was tested using the E2E test case.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.70%. Comparing base (608af4f) to head (ec062ad).
⚠️ Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...identity/davinci/collector/PhoneNumberCollector.kt 50.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             develop     #177       +/-   ##
==============================================
+ Coverage      27.66%   46.70%   +19.04%     
- Complexity       901     1270      +369     
==============================================
  Files            299      305        +6     
  Lines           8957     9213      +256     
  Branches        1272     1310       +38     
==============================================
+ Hits            2478     4303     +1825     
+ Misses          6195     4337     -1858     
- Partials         284      573      +289     
Flag Coverage Δ
integration-tests 26.56% <50.00%> (?)
unit-tests 27.68% <37.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vibhorgoswami vibhorgoswami force-pushed the SDKS-4669 branch 2 times, most recently from f8ccb51 to 400076c Compare April 2, 2026 16:25
@vibhorgoswami vibhorgoswami requested review from spetrov and witrisna and removed request for witrisna April 2, 2026 16:27
@vibhorgoswami vibhorgoswami marked this pull request as ready for review April 2, 2026 16:27
@vibhorgoswami vibhorgoswami self-assigned this Apr 2, 2026
@vibhorgoswami vibhorgoswami requested a review from witrisna April 2, 2026 16:35
@vibhorgoswami vibhorgoswami force-pushed the SDKS-4669 branch 2 times, most recently from 2de24b8 to 6206f24 Compare April 2, 2026 17:07
Copy link
Copy Markdown
Contributor

@spetrov spetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@spetrov spetrov merged commit 6103338 into develop Apr 15, 2026
16 of 17 checks passed
@spetrov spetrov deleted the SDKS-4669 branch April 15, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants