Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #171 +/- ##
==============================================
+ Coverage 27.65% 46.63% +18.97%
- Complexity 901 1263 +362
==============================================
Files 300 306 +6
Lines 8967 9215 +248
Branches 1271 1305 +34
==============================================
+ Hits 2480 4297 +1817
+ Misses 6205 4347 -1858
- Partials 282 571 +289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates a changelog reference, adjusts README wording for module names, bumps a library version, adds an Android debug signing config to the sample app, changes BrowserStack job dependencies in CI, and modifies/annotates two Android tests (one assertion change, one test ignored). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@external-idp/README.md`:
- Line 10: The README has inconsistent module names: lines reference
`davinci`/`journey` while later lines reference `ping-davinci`/`ping-journey`;
update the README so module naming is consistent end-to-end by choosing one
convention (either drop the `ping-` prefix or use it everywhere), replace all
occurrences of `davinci`/`journey` or `ping-davinci`/`ping-journey` accordingly,
and ensure any example commands, configuration snippets, and the setup
instructions (where `davinci`, `journey`, `ping-davinci`, `ping-journey` appear)
match the chosen naming scheme.
In `@gradle/libs.versions.toml`:
- Line 56: The dependency com-pingidentity-signals = "5.3.0" targets Android API
level 36; before releasing 2.0.0, verify your build toolchain can compile
against Android 16 by updating or confirming compileSdk is set to 36 (or a
compatible higher value) in your module build.gradle/kts, ensure the Android
Gradle Plugin and Gradle wrapper versions support API 36 (bump AGP/Gradle if
needed), run a full clean build and unit/instrumented tests, and check for any
deprecation/compat warnings introduced by Signals 5.3.0 during compilation and
runtime.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5095e5e9-3681-4415-8b11-76628a363532
📒 Files selected for processing (4)
CHANGELOG.mdexternal-idp/README.mdgradle/libs.versions.tomlsamples/pingsampleapp/build.gradle.kts
| startupRuntime = "1.2.0" | ||
|
|
||
| com-pingidentity-signals = "5.2.0" | ||
| com-pingidentity-signals = "5.3.0" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What are the release notes and any breaking changes for com.pingidentity.signals:android-sdk 5.3.0 compared to 5.2.0?
💡 Result:
Release notes (Android) — com.pingidentity.signals:android-sdk
5.3.0 (released Jan 21, 2026)
- Targeted for API Level 36 (Android 16). [1]
5.2.0 (released Mar 23, 2025)
- Location signal change: when the host app has requested location permissions, the SDK “takes into account GPS data” for user location information. [1]
Breaking changes / upgrade risks (5.2.0 → 5.3.0)
- No explicit breaking changes are called out in Ping’s Android SDK changelog beyond the move to target API level 36. [1]
- Practical impact to watch for: because 5.3.0 targets Android 16 / API 36, you may need a build toolchain that supports compiling against newer Android SDK levels (for example, updating your project’s Android SDK /
compileSdk, and potentially AGP/Gradle), depending on how the AAR is built and what APIs it references. (This is an upgrade risk implied by the targeting change; Ping does not label it as a “breaking change” in the notes.) [1]
Source
- [1] PingOne Protect “SDK Changelog” (Signals SDK for Android) — version entries for 5.2.0 and 5.3.0. (developer.pingidentity.com)
Citations:
Verify Android API level 36 (Android 16) compatibility for 2.0.0 release.
Signals 5.3.0 targets API Level 36, introduced in January 2026. While no explicit breaking changes are documented in the changelog, this API level bump requires verification that your build toolchain (compileSdk, AGP/Gradle) can support compiling against Android 16 before cutting the release.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@gradle/libs.versions.toml` at line 56, The dependency
com-pingidentity-signals = "5.3.0" targets Android API level 36; before
releasing 2.0.0, verify your build toolchain can compile against Android 16 by
updating or confirming compileSdk is set to 36 (or a compatible higher value) in
your module build.gradle/kts, ensure the Android Gradle Plugin and Gradle
wrapper versions support API 36 (bump AGP/Gradle if needed), run a full clean
build and unit/instrumented tests, and check for any deprecation/compat warnings
introduced by Signals 5.3.0 during compilation and runtime.
spetrov
force-pushed
the
SDKS-4808
branch
2 times, most recently
from
2ee2e13 to
452e89b
Compare
2 participants
JIRA Ticket
SDKS-4808 Release test and activities for Ping SDK 2.0.0
Description
Summary by CodeRabbit
Documentation
Chores
Tests