fix: convert data retention period deltas to challenges#429
Merged
silent-cipher merged 3 commits intomainfrom Apr 3, 2026
Merged
fix: convert data retention period deltas to challenges#429silent-cipher merged 3 commits intomainfrom
silent-cipher merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts backend data-retention metrics to resolve the semantic mismatch between proving periods and challenges (per issue #89), ensuring the Prometheus counters represent challenges rather than periods.
Changes:
- Introduces a
CHALLENGES_PER_PROVING_PERIODconstant (5) and applies it to period deltas. - Converts faulted/success deltas from proving periods into challenge deltas before incrementing
dataSetChallengeStatuscounters. - Updates in-code documentation and log field names to reflect “challenges delta”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BigLep
approved these changes
Apr 2, 2026
github-project-automation
bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the semantic mismatch between Challenges and Proving Periods, as discussed in FilOzone/pdp-explorer#89.