Pqc falcon512

[Federico2014]

What does this PR do?

Why are these changes required?

This PR has been tested by:

• Unit Tests
• Manual Testing

Follow up

Extra details

---

Summary by cubic

Gate Falcon-512 (FN-DSA-512) signatures behind governance activation and bundle PQ priv/pub keys into a single PqKeypair. This prevents config mistakes, tightens signature checks, and keeps legacy behavior until PQ is enabled.

• Refactors

  • Added PqKeypair and replaced parallel PQ key lists in LocalWitnesses; Args now parses extended hex entries into pairs; updated WitnessInitializer.initFromPQOnly.
  • ConsensusService and RelayService now consume List<PqKeypair> for single/multi-witness setups.
  • BlockCapsule: PQ validation runs only when isAnyPqSchemeAllowed() is true; derived PQ public key address must equal the witness permission address; hasWitnessSignature now requires DynamicPropertiesStore.
  • Transactions: TransactionUtil.getTransactionSignWeight gates PQ checks on isAnyPqSchemeAllowed(), uses TransactionCapsule.validatePQSignatureGetWeight, and always sets approve list and current weight.
  • TransactionCapsule: renamed PQ validator to validatePQSignatureGetWeight and manages its own dedup set.
  • Call sites updated: VMActuator/Manager pass DynamicPropertiesStore; CPU limit ratio helper now takes DynamicPropertiesStore.

• Migration

  • Replace calls to LocalWitnesses#getPqPrivateKeys()/getPqPublicKeys() with getPqKeypairs().
  • Updated APIs: WitnessInitializer.initFromPQOnly(PQScheme, List<PqKeypair>, String), BlockCapsule#hasWitnessSignature(DynamicPropertiesStore), TransactionCapsule.validatePQSignatureGetWeight(...), and VMActuator#getCpuLimitInUsRatio(DynamicPropertiesStore).
  • Behavior change: PQ-only blocks and PQ tx signatures are ignored until a PQ scheme is activated (e.g., saveAllowFnDsa512(1)), preserving pre-activation semantics.

^{Written for commit bd79efc. Summary will update on new commits. Review in cubic}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 66b48fe1-d4c8-46df-88db-8fc1aac670b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

3 issues found across 14 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="chainbase/src/main/java/org/tron/common/utils/PqKeypair.java">

<violation number="1" location="chainbase/src/main/java/org/tron/common/utils/PqKeypair.java:12">
P1: `@Value` generates `toString()` including `privateKey`, which can leak secret key material in logs. Exclude this field from `toString()` generation.</violation>
</file>

<file name="chainbase/src/main/java/org/tron/core/capsule/BlockCapsule.java">

<violation number="1" location="chainbase/src/main/java/org/tron/core/capsule/BlockCapsule.java:211">
P1: Missing null-check on witness account can throw NullPointerException during signature validation.</violation>

<violation number="2" location="chainbase/src/main/java/org/tron/core/capsule/BlockCapsule.java:259">
P1: PQ signature address matching is restricted to a single witness key, which can reject valid signatures from other configured witness permission keys.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Re-trigger cubic}

[cubic-dev-ai]

P1: @Value generates toString() including privateKey, which can leak secret key material in logs. Exclude this field from toString() generation.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At chainbase/src/main/java/org/tron/common/utils/PqKeypair.java, line 12:

<comment>`@Value` generates `toString()` including `privateKey`, which can leak secret key material in logs. Exclude this field from `toString()` generation.</comment>

<file context>
@@ -0,0 +1,14 @@
+ */
+@Value
+public class PqKeypair {
+  String privateKey;
+  String publicKey;
+}
</file context>

[cubic-dev-ai]

P1: PQ signature address matching is restricted to a single witness key, which can reject valid signatures from other configured witness permission keys.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At chainbase/src/main/java/org/tron/core/capsule/BlockCapsule.java, line 259:

<comment>PQ signature address matching is restricted to a single witness key, which can reject valid signatures from other configured witness permission keys.</comment>

<file context>
@@ -262,38 +249,22 @@ private boolean validatePQSignature(DynamicPropertiesStore dynamicPropertiesStor
-        matched = k;
-        break;
-      }
+    if (!Arrays.equals(derivedAddr, witnessPermissionAddress)) {
+      throw new ValidateSignatureException(
+          "pq_auth_sig public key does not match witness permission address");
</file context>

[cubic-dev-ai]

P1: Missing null-check on witness account can throw NullPointerException during signature validation.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At chainbase/src/main/java/org/tron/core/capsule/BlockCapsule.java, line 211:

<comment>Missing null-check on witness account can throw NullPointerException during signature validation.</comment>

<file context>
@@ -203,41 +201,27 @@ private Sha256Hash getRawHash() {
+    if (dynamicPropertiesStore.getAllowMultiSign() != 1) {
+      witnessPermissionAddress = witnessAccountAddress;
+    } else {
+      witnessPermissionAddress = accountStore.get(witnessAccountAddress)
+          .getWitnessPermissionAddress();
     }
</file context>