Fix bugs with home location and waypoints not being displayed correctly#635
Merged
1Blademaster merged 1 commit intorelease-alpha-0.1.10from Aug 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bugs related to the display of home location and waypoints in a mission management system. The changes address issues with incorrect sequence numbering, filtering of mission items, and improve the handling of home commands in both Python controller code and JavaScript frontend components.
Key changes:
- Fixed off-by-one errors in mission item sequence numbering across Python logging and JavaScript UI
- Replaced hardcoded filtering logic with a reusable
isGlobalFrameHomeCommandfunction - Removed unused Redux selector and simplified mission item filtering
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| radio/app/controllers/missionController.py | Fixed sequence numbering in logging messages to use 1-based indexing |
| gcs/src/redux/slices/missionSlice.js | Removed unused Redux selector for filtered mission items |
| gcs/src/helpers/filterMissions.js | Refactored filtering logic to use dedicated home command detection |
| gcs/src/components/missions/*.jsx | Updated table components to use seq property instead of array index |
| gcs/src/components/mapComponents/missionItems.jsx | Fixed text display for mission item sequence numbers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.