Skip to content

Add check and error message for mission item and mission type#601

Merged
NexInfinite merged 2 commits intorelease-alpha-0.1.10from
alpha-0.1.10/600-show-error-if-incorrect-mission-item-type-detected-when-importing-file
Aug 6, 2025
Merged

Add check and error message for mission item and mission type#601
NexInfinite merged 2 commits intorelease-alpha-0.1.10from
alpha-0.1.10/600-show-error-if-incorrect-mission-item-type-detected-when-importing-file

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

Closes #600

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation to ensure that mission waypoint commands match the specified mission type when importing mission files. It prevents mismatched commands from being loaded by checking waypoint command types against the expected mission type (rally, fence, or mission).

Key Changes

  • Added comprehensive validation logic to check waypoint command compatibility with mission types
  • Implemented error handling and user-friendly error messages for mismatched commands
  • Added logging for debugging purposes when validation fails

Comment thread radio/app/controllers/missionController.py Outdated
Comment thread radio/app/controllers/missionController.py Outdated
Comment thread radio/app/controllers/missionController.py Outdated
Copy link
Copy Markdown
Contributor

@NexInfinite NexInfinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@NexInfinite NexInfinite merged commit e0c48fa into release-alpha-0.1.10 Aug 6, 2025
7 checks passed
@NexInfinite NexInfinite deleted the alpha-0.1.10/600-show-error-if-incorrect-mission-item-type-detected-when-importing-file branch August 6, 2025 12:04
1Blademaster added a commit that referenced this pull request Sep 28, 2025
* Add check and error message for mission item and mission type

* Address copilot review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show error if incorrect mission item type detected when importing file

3 participants