Alpha 0.1.10/592 add rally point functionality to missions#599
Merged
1Blademaster merged 3 commits intorelease-alpha-0.1.10from Aug 3, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds rally point functionality to the missions system, enabling users to create, edit, and delete rally points alongside existing mission and fence capabilities. The changes unify the handling of different mission types (mission, fence, rally) under a common interface while adding rally-specific features.
Key changes:
- Unified mission item creation, update, and deletion functions to handle all mission types (mission, fence, rally)
- Added rally point support to the map interface with proper visual indicators and drag functionality
- Enhanced rally items table with delete functionality and proper column structure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| gcs/src/missions.jsx | Core logic for unified mission item handling and rally point creation with home position support |
| gcs/src/components/missions/rallyItemsTableRow.jsx | Added delete functionality and proper table structure for rally items |
| gcs/src/components/missions/rallyItemsTable.jsx | Updated table interface to support delete operations |
| gcs/src/components/missions/missionsMap.jsx | Unified map marker handling and added sequence numbers to rally points |
1Blademaster
deleted the
alpha-0.1.10/592-add-rally-point-functionality-to-missions
branch
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Start adding rally functionality to missions page * Finish adding rally point functionality * Address copilot comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.