Skip to content

Add insert waypoint button between mission items#1180

Merged
1Blademaster merged 2 commits intomainfrom
1170-feature-add-new-waypoints-by-clicking-on-middle-of-adjoining-line
Apr 24, 2026
Merged

Add insert waypoint button between mission items#1180
1Blademaster merged 2 commits intomainfrom
1170-feature-add-new-waypoints-by-clicking-on-middle-of-adjoining-line

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 20:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds UI affordances to insert new mission waypoints (and fence polygon vertices) directly from the map by rendering clickable midpoint “+” markers between adjacent items, with corresponding Redux reducers to insert and re-sequence items.

Changes:

  • Added insertDrawingItemAfter (generic) and insertFencePolygonVertex (polygon-aware) reducers to insert items and re-sequence lists.
  • Rendered midpoint insert buttons on the mission and fence map overlays and wired them to the new reducers.
  • Hardened mission/fence/rally table numeric input handling by ignoring non-finite/empty intermediate values from Mantine NumberInput.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
gcs/src/redux/slices/missionSlice.js Adds reducers for inserting a mission item after an existing item and inserting a fence polygon vertex while updating seq/param1/z.
gcs/src/components/missions/rallyItemsTableRow.jsx Adds numeric parsing guard to avoid writing invalid intermediate input values into state.
gcs/src/components/missions/missionItemsTableRow.jsx Adds numeric parsing guards (and a coordinate-specific helper) for mission item table edits.
gcs/src/components/missions/fenceItemsTableRow.jsx Adds numeric parsing guard to avoid writing invalid intermediate input values into state.
gcs/src/components/mapComponents/missionItems.jsx Computes mission path midpoints and renders clickable midpoint insert buttons that dispatch insertion actions.
gcs/src/components/mapComponents/midpointInsertButton.jsx New reusable map marker button component for midpoint “+” insertion.
gcs/src/components/mapComponents/fenceItems.jsx Groups fence polygons, computes edge midpoints, renders insert buttons, and dispatches polygon-vertex insertion actions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gcs/src/components/missions/missionItemsTableRow.jsx
Comment thread gcs/src/components/missions/missionItemsTableRow.jsx
Comment thread gcs/src/components/missions/fenceItemsTableRow.jsx
Comment thread gcs/src/components/missions/rallyItemsTableRow.jsx
@1Blademaster 1Blademaster merged commit 943284c into main Apr 24, 2026
1 check passed
@1Blademaster 1Blademaster deleted the 1170-feature-add-new-waypoints-by-clicking-on-middle-of-adjoining-line branch April 24, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add new waypoints by clicking on middle of adjoining line

2 participants