Add heartbeat timeout warning#1164
Merged
1Blademaster merged 2 commits intomainfrom Apr 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GCS-side heartbeat “stale” warning so operators are notified when heartbeats stop arriving, and introduces supporting Redux state/middleware to track last heartbeat receipt time.
Changes:
- Track
heartbeatMonitor.lastReceivedAtindroneInfoSliceand update/reset it via a new Redux middleware. - Add a non-dismissible “Heartbeat” alert in the dashboard status bar when heartbeats are stale past a configurable timeout.
- Add a new default setting
Dashboard.heartbeatTimeoutSecondsand make alert dismissal respectdismissable: false.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/drone.py | Invokes droneDisconnectCb() during close() cleanup |
| gcs/src/redux/store.js | Registers new heartbeatMonitorMiddleware |
| gcs/src/redux/slices/droneInfoSlice.js | Adds heartbeat monitor state, reducers, selector |
| gcs/src/redux/middleware/heartbeatMonitorMiddleware.js | Updates/resets lastReceivedAt based on connection/heartbeat actions |
| gcs/src/components/dashboard/statusBar.jsx | Implements periodic heartbeat timeout check + alert |
| gcs/src/components/dashboard/alerts/alertProvider.jsx | Prevents dismissing non-dismissible alerts and guards missing alerts |
| gcs/src/components/dashboard/alerts/alertConstants.js | Adds AlertCategory.Heartbeat |
| gcs/src/components/dashboard/alerts/alert.jsx | Hides close button and disables onClose for non-dismissible alerts |
| gcs/data/default_settings.json | Adds configurable heartbeat timeout setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.